Devin's feedback

deephaven · Jan 9, 2024 · e9a13da · e9a13da
1 parent 9b5978d
commit e9a13da
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/server/src/main/java/io/deephaven/server/console/ConsoleServiceGrpcImpl.java b/server/src/main/java/io/deephaven/server/console/ConsoleServiceGrpcImpl.java
@@ -312,14 +312,12 @@ public StreamObserver<AutoCompleteRequest> autoCompleteStream(
                         "from deephaven_internal.auto_completer import jedi_settings ; jedi_settings.set_scope(globals())");
                 settings[0] = (PyObject) scriptSession.getVariable("jedi_settings");
             } catch (Exception err) {
-                if (err instanceof QueryScope.MissingVariableException) {
-                    if (!ALREADY_WARNED_ABOUT_NO_AUTOCOMPLETE.getAndSet(true)) {
-                        log.error().append("Autocomplete package not found; disabling autocomplete.").endl();
-                        log.error().append("Add the jvm flag '-D").append(DISABLE_AUTOCOMPLETE_FLAG)
-                                .append("=true' to disable this message.").endl();
-                    }
-                } else {
-                    log.error().append("Error trying to enable jedi autocomplete").append(err).endl();
+                if (!ALREADY_WARNED_ABOUT_NO_AUTOCOMPLETE.getAndSet(true)) {
+                    log.error().append("Autocomplete package not found; disabling autocomplete.").endl();
+                    log.error().append("Do you need to install the autocomplete package?").endl();
+                    log.error().append("    pip install deephaven-core[autocomplete]==<version>").endl();
+                    log.error().append("Add the jvm flag '-D").append(DISABLE_AUTOCOMPLETE_FLAG)
+                            .append("=true' to disable this message.").endl();
                 }
             }
             boolean canJedi = settings[0] != null && settings[0].call("can_jedi").getBooleanValue();