Skip to content

Commit

Permalink
update references from deephaven/core to deephaven/deephaven-core (#551)
Browse files Browse the repository at this point in the history
  • Loading branch information
devinrsmith authored May 9, 2021
1 parent 6013c63 commit e709268
Show file tree
Hide file tree
Showing 21 changed files with 41 additions and 41 deletions.
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ labels: bug, triage

---

<!-- Please read our Code of Conduct: https://github.com/deephaven/core/blob/main/CODE_OF_CONDUCT.md -->
<!-- Please read our Code of Conduct: https://github.com/deephaven/deephaven-core/blob/main/CODE_OF_CONDUCT.md -->
<!-- Please search existing issues to avoid creating duplicates. -->

**Description**
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/epic.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ labels: epic, triage

---

<!-- Please read our Code of Conduct: https://github.com/deephaven/core/blob/main/CODE_OF_CONDUCT.md -->
<!-- Please read our Code of Conduct: https://github.com/deephaven/deephaven-core/blob/main/CODE_OF_CONDUCT.md -->
<!-- Please search existing issues to avoid creating duplicates. -->

[Description of body of work]
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ labels: feature request, triage

---

<!-- Please read our Code of Conduct: https://github.com/deephaven/core/blob/main/CODE_OF_CONDUCT.md -->
<!-- Please read our Code of Conduct: https://github.com/deephaven/deephaven-core/blob/main/CODE_OF_CONDUCT.md -->
<!-- Please search existing issues to avoid creating duplicates. -->

<!-- Describe the feature you'd like. -->
Expand Down
2 changes: 1 addition & 1 deletion .github/tools/deephaven-gh-runner-init.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ set -e
########################################

GH_RUNNER_VERSION=${GH_RUNNER_VERSION:="2.277.1"}
GH_RUNNER_REPO_URL=${GH_RUNNER_REPO_URL:="https://github.com/deephaven/core"}
GH_RUNNER_REPO_URL=${GH_RUNNER_REPO_URL:="https://github.com/deephaven/deephaven-core"}
GH_RUNNER_TOKEN=${GH_RUNNER_TOKEN:?""}
GH_RUNNER_NAME=${GH_RUNNER_NAME:=$HOSTNAME}
GH_RUNNER_LABELS=${GH_RUNNER_LABELS:="gce-runner,benchmark"}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public BenchmarkTable build() {
throw new IllegalStateException("Grouping requested on the following nonexistant columns " + StringUtils.joinStrings(missingGroupingColumns,", "));
}

// TODO (deephaven/core/issues/147): Replace this with a Parquet-backed table, or delete this entirely and use in-memory always
// TODO (deephaven/deephaven-core/issues/147): Replace this with a Parquet-backed table, or delete this entirely and use in-memory always
return new InMemoryBenchmarkTable(name, size, rngSeed, getColumnGenerators());
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
public enum TreeTableClientTableManager {
DEFAULT;

// TODO (deephaven/core/issues/37): Refine this type into something useful, or refactor entirely.
// TODO (deephaven/deephaven-core/issues/37): Refine this type into something useful, or refactor entirely.
public interface Client<CLIENT_TYPE extends Client<CLIENT_TYPE>> {
void addDisconnectHandler(@NotNull Consumer<CLIENT_TYPE> handler);
void removeDisconnectHandler(@NotNull Consumer<CLIENT_TYPE> handler);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1414,7 +1414,7 @@ public static Table merge(Collection<Table> tables) {
*/
public static Table merge(Table... tables) {
return QueryPerformanceRecorder.withNugget("merge", () -> {
// TODO (deephaven/core/issues/257): When we have a new Table proxy implementation, we should reintroduce remote merge for proxies.
// TODO (deephaven/deephaven-core/issues/257): When we have a new Table proxy implementation, we should reintroduce remote merge for proxies.
// If all of the tables are proxies, then we should ship this request over rather than trying to do it locally.
// Table proxyMerge = io.deephaven.db.tables.utils.TableTools.mergeByProxy(tables);
// if (proxyMerge != null) {
Expand Down
2 changes: 1 addition & 1 deletion DB/src/main/java/io/deephaven/db/util/DBColorUtil.java
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
* For foreground colors, one of the remaining 7 bits denotes
* no foreground color overriding when the cell is highlighted in the table.
* This means the foreground color will stay the same when the cell is highlighted.
* TODO (deephaven/core/issues/175): Move this to a new module and package
* TODO (deephaven/deephaven-core/issues/175): Move this to a new module and package
*/
@SuppressWarnings({"UnusedDeclaration", "WeakerAccess"})
public class DBColorUtil extends DBColorUtilImpl {
Expand Down
2 changes: 1 addition & 1 deletion DB/src/main/java/io/deephaven/db/util/DBColorUtilImpl.java
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* without importing the color fields.
* TODO: remove once {@link DBColorUtil} field and {@link Color} field conflicts are resolved.
* TODO: This class won't be necessary once we can import DBColorUtil as static again.
* TODO (deephaven/core/issues/175): Move this to a new module and package
* TODO (deephaven/deephaven-core/issues/175): Move this to a new module and package
*/
public class DBColorUtilImpl {
public static final long COLOR_SET_BIT = 0x01;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ default boolean hasColumn(String columnName) {
* Queries whether this MutableInputTable is editable in the current context.
*
* @return true if this MutableInputTable may be edited, false otherwise
* TODO (deephaven/core/issues/255): Add AuthContext and whatever else is appropriate
* TODO (deephaven/deephaven-core/issues/255): Add AuthContext and whatever else is appropriate
*/
boolean canEdit();
}
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public static void log(DBDateTime time, UpdatePerformanceTracker.Entry entry, Up
failingOperationNumberSetter.setInt(sourceEntry.getOperationNumber());
failingDescriptionSetter.set(sourceEntry.getDescription());
}
// TODO (deephaven/core/issues/159): Do we continue supporting this? If so, we should consider fixing host name and worker name.
// TODO (deephaven/deephaven-core/issues/159): Do we continue supporting this? If so, we should consider fixing host name and worker name.
workerNameSetter.set(null);
hostNameSetter.set(null);
causeSetter.set(originalException);
Expand Down
2 changes: 1 addition & 1 deletion DB/src/main/java/io/deephaven/gui/color/Color.java
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
/**
* A color.
* @IncludeAll
* TODO (deephaven/core/issues/175): Move this to a new module and package
* TODO (deephaven/deephaven-core/issues/175): Move this to a new module and package
*/
@SuppressWarnings("WeakerAccess")
public class Color implements Paint, Serializable {
Expand Down
2 changes: 1 addition & 1 deletion DB/src/main/java/io/deephaven/gui/color/Colors.java
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
*
* Methods and colors moved from DBColorUtil to here. They are left in DBColorUtil
* for backward compatibility.
* TODO (deephaven/core/issues/175): Move this to a new module and package
* TODO (deephaven/deephaven-core/issues/175): Move this to a new module and package
*/
public enum Colors {
//color constants from https://www.w3schools.com/colors/colorsnames.asp
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ public void testWriteTableEmpty() throws IOException {

@Test
public void testWriteTableMissingColumns() {
// TODO (deephaven/core/issues/321): Fix the apparent bug in the parquet table writer.
// TODO (deephaven/deephaven-core/issues/321): Fix the apparent bug in the parquet table writer.
// final Table nullTable = TableTools.emptyTable(10_000L).updateView(
// "B = NULL_BYTE",
// "C = NULL_CHAR",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ public class TestMapCodecColumns {
public void doColumnsTest() throws IOException {
final File dir = Files.createTempDirectory(Paths.get(""), "CODEC_TEST").toFile();
TableManagementTools.writeTable(TABLE, dir, storageFormat);
// TODO (deephaven/core/issues/322): Infer the definition
// TODO (deephaven/deephaven-core/issues/322): Infer the definition
final Table result = TableManagementTools.readTable(dir, TABLE_DEFINITION);
TableTools.show(result);
TestCase.assertEquals(TABLE_DEFINITION, result.getDefinition());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ private void doTest(final boolean missingGroups) {
.mapToObj(pcv -> new File(dataDirectory, "IP" + File.separator + String.format("%04d", pcv) + File.separator + tableKey.getTableName()))
.toArray(File[]::new)
);
// TODO (deephaven/core/issues/321): Re-add this part of the test when the parquet bug is fixed
// TODO (deephaven/deephaven-core/issues/321): Re-add this part of the test when the parquet bug is fixed
// TableManagementTools.writeTable(TableTools.emptyTable(0).updateView("Sym=NULL_CHAR", "Other=NULL_LONG"), partitionedDataDefinition,
// new File(dataDirectory, "IP" + File.separator + "XXXX" + File.separator + tableKey.getTableName()), TableManagementTools.StorageFormat.Parquet);

Expand Down
2 changes: 1 addition & 1 deletion LICENSE.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Deephaven Community License Agreement (the "Agreement").
Software provided to the original licensee with this Agreement. The Software may
include third party owned code. Each third party module is subject to the terms
of its respective license; the details of which can be found in the notices
served at [https://github.com/deephaven/core](https://github.com/deephaven/core).
served at [https://github.com/deephaven/deephaven-core](https://github.com/deephaven/deephaven-core).
Since licensees may contribute back to the Software as provided for in Section
3(b), the Software may include any such contributions.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ public FigureDescriptor translate(DisplayableFigureDescriptor descriptor) {

clientFigure.setUpdateInterval(figure.getUpdateInterval());

// TODO (deephaven/core/41): Update this to match new DisplayableFigureDescriptor and whatever the JS plotting API needs post-GRPC.
// TODO (deephaven/deephaven-core/41): Update this to match new DisplayableFigureDescriptor and whatever the JS plotting API needs post-GRPC.
// final int[] tableHandleIds = new int[descriptor.getDeflatedTables().size()];
// for (int i = 0; i < descriptor.getDeflatedTables().size(); i++) {
// final ExportedTableDescriptorMessage t = (ExportedTableDescriptorMessage) descriptor.getDeflatedTables().get(i);
Expand Down
14 changes: 7 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ to that data, and build rich queries, dashboards, and representations with the r
Deephaven Community Core is an open version of [Deephaven Enterprise](https://deephaven.io),
which functions as the data backbone for prominent hedge funds, banks, and financial exchanges.

![Build CI](https://github.com/deephaven/core/actions/workflows/build-ci.yml/badge.svg)
![Check CI](https://github.com/deephaven/core/actions/workflows/check-ci.yml/badge.svg)
![Long Check CI](https://github.com/deephaven/core/actions/workflows/long-check-ci.yml/badge.svg)
![Nightly Check CI](https://github.com/deephaven/core/actions/workflows/nightly-check-ci.yml/badge.svg)
![Nightly Benchmarks](https://github.com/deephaven/core/actions/workflows/nightly-benchmarks.yml/badge.svg)
![Workflow Sync](https://github.com/deephaven/core/actions/workflows/workflow-sync.yml/badge.svg)
![Build CI](https://github.com/deephaven/deephaven-core/actions/workflows/build-ci.yml/badge.svg)
![Check CI](https://github.com/deephaven/deephaven-core/actions/workflows/check-ci.yml/badge.svg)
![Long Check CI](https://github.com/deephaven/deephaven-core/actions/workflows/long-check-ci.yml/badge.svg)
![Nightly Check CI](https://github.com/deephaven/deephaven-core/actions/workflows/nightly-check-ci.yml/badge.svg)
![Nightly Benchmarks](https://github.com/deephaven/deephaven-core/actions/workflows/nightly-benchmarks.yml/badge.svg)
![Workflow Sync](https://github.com/deephaven/deephaven-core/actions/workflows/workflow-sync.yml/badge.svg)

## Supported Languages

Expand Down Expand Up @@ -122,7 +122,7 @@ docker run hello-world
Once all of the required dependencies are installed and functioning, run:
```
git clone [email protected]:deephaven/core.git
git clone [email protected]:deephaven/deephaven-core.git
cd core
./gradlew prepareCompose
docker-compose build
Expand Down
30 changes: 15 additions & 15 deletions TRIAGE.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,22 +2,22 @@

Loosely based on the [VSCode triage process](https://github.com/microsoft/vscode/wiki/Issues-Triaging) (not as automated - yet).

1. File an issue using the [Bug Report](https://github.com/deephaven/core/issues/new?assignees=&labels=bug%2C+triage&template=bug_report.md) or the [Feature Request](https://github.com/deephaven/core/issues/new?assignees=&labels=feature+request%2C+triage&template=feature_request.md) template. The issue will be created with the `Triage` label.
2. The issue triager (weekly rotating role) goes through the unassigned [`triage` issues](https://github.com/deephaven/core/labels/triage), assigning to the appropriate feature area owner. By assigning it directly to someone, they will see the issue on their issue list, and can see it needs triaging because of the `triage` label. If you are unsure who to assign it to, take your best guess and the owner can re-assign if it is not for them:
- [web ui](https://github.com/deephaven/core/issues?q=is%3Aopen+is%3Aissue+no%3Amilestone+label%3A%22web+ui%22) - Bender
- [core](https://github.com/deephaven/core/issues?q=is%3Aopen+is%3Aissue+no%3Amilestone+label%3Acore+) - Ryan
- [build](https://github.com/deephaven/core/issues?q=is%3Aopen+is%3Aissue+no%3Amilestone+label%3Abuild+) - Devin
- [grpc](https://github.com/deephaven/core/issues?q=is%3Aopen+is%3Aissue+no%3Amilestone+label%3Agrpc+) - Nate
- [community](https://github.com/deephaven/core/issues?q=is%3Aopen+is%3Aissue+no%3Amilestone+label%3Acommunity) - Chip
3. Area owners [triage tickets assigned to them](https://github.com/deephaven/core/issues?q=is%3Aopen+label%3Atriage+assignee%3A%40me+) by adding appropriate labels, any additional comments, and adding to the backlog if it is an accepted issue.
1. File an issue using the [Bug Report](https://github.com/deephaven/deephaven-core/issues/new?assignees=&labels=bug%2C+triage&template=bug_report.md) or the [Feature Request](https://github.com/deephaven/deephaven-core/issues/new?assignees=&labels=feature+request%2C+triage&template=feature_request.md) template. The issue will be created with the `Triage` label.
2. The issue triager (weekly rotating role) goes through the unassigned [`triage` issues](https://github.com/deephaven/deephaven-core/labels/triage), assigning to the appropriate feature area owner. By assigning it directly to someone, they will see the issue on their issue list, and can see it needs triaging because of the `triage` label. If you are unsure who to assign it to, take your best guess and the owner can re-assign if it is not for them:
- [web ui](https://github.com/deephaven/deephaven-core/issues?q=is%3Aopen+is%3Aissue+no%3Amilestone+label%3A%22web+ui%22) - Bender
- [core](https://github.com/deephaven/deephaven-core/issues?q=is%3Aopen+is%3Aissue+no%3Amilestone+label%3Acore+) - Ryan
- [build](https://github.com/deephaven/deephaven-core/issues?q=is%3Aopen+is%3Aissue+no%3Amilestone+label%3Abuild+) - Devin
- [grpc](https://github.com/deephaven/deephaven-core/issues?q=is%3Aopen+is%3Aissue+no%3Amilestone+label%3Agrpc+) - Nate
- [community](https://github.com/deephaven/deephaven-core/issues?q=is%3Aopen+is%3Aissue+no%3Amilestone+label%3Acommunity) - Chip
3. Area owners [triage tickets assigned to them](https://github.com/deephaven/deephaven-core/issues?q=is%3Aopen+label%3Atriage+assignee%3A%40me+) by adding appropriate labels, any additional comments, and adding to the backlog if it is an accepted issue.
- Tickets may have additional labels added, dependencies linked, and/or comments added.
- If more information is required, add the [`needs more info` label](https://github.com/deephaven/core/labels/needs%20more%20info), and re-assign to the creator.
- If it's a duplicate of an existing issue, add the [`duplicate` label](https://github.com/deephaven/core/labels/duplicate), and close the issue with a comment linking to the issue it duplicates.
- If the issue is important, such as a blocking issue or a security vulnerability, add the [`important`](https://github.com/deephaven/core/labels/important) label, and assign to the current milestone as necessary.
- After the issue has been validated, add an appropriate area label, remove the `triage` label, unassign yourself as the owner, and add it to the [Backlog milestone](https://github.com/deephaven/core/milestone/11). It will be assigned to a milestone when doing monthly planning.
4. Developers work on tickets assigned to them within the current milestone. Since only tickets that you are working on will be assigned to you, [your issue list](https://github.com/deephaven/core/issues/assigned/@me) should stay trim/easy to manage.
5. Anybody (within the company or community) can vote on issues in the backlog using reactions. The issues with the most upvotes will be prioritized higher in the [backlog issue list](https://github.com/deephaven/core/issues?q=is%3Aopen+milestone%3ABacklog+sort%3Areactions-%2B1-desc).
- If more information is required, add the [`needs more info` label](https://github.com/deephaven/deephaven-core/labels/needs%20more%20info), and re-assign to the creator.
- If it's a duplicate of an existing issue, add the [`duplicate` label](https://github.com/deephaven/deephaven-core/labels/duplicate), and close the issue with a comment linking to the issue it duplicates.
- If the issue is important, such as a blocking issue or a security vulnerability, add the [`important`](https://github.com/deephaven/deephaven-core/labels/important) label, and assign to the current milestone as necessary.
- After the issue has been validated, add an appropriate area label, remove the `triage` label, unassign yourself as the owner, and add it to the [Backlog milestone](https://github.com/deephaven/deephaven-core/milestone/11). It will be assigned to a milestone when doing monthly planning.
4. Developers work on tickets assigned to them within the current milestone. Since only tickets that you are working on will be assigned to you, [your issue list](https://github.com/deephaven/deephaven-core/issues/assigned/@me) should stay trim/easy to manage.
5. Anybody (within the company or community) can vote on issues in the backlog using reactions. The issues with the most upvotes will be prioritized higher in the [backlog issue list](https://github.com/deephaven/deephaven-core/issues?q=is%3Aopen+milestone%3ABacklog+sort%3Areactions-%2B1-desc).

# Monthly Planning/Backlog Grooming

Each feature area owner (with support from their team) will do backlog grooming by looking at the [backlog issue list](https://github.com/deephaven/core/issues?q=is%3Aopen+milestone%3ABacklog+sort%3Areactions-%2B1-desc), breaking down issues into concise chunks with a clear definition of done, and assigning what they think they can get done in the next month. Be aware of dependencies, and work with the product manager in addition to the upvotes for prioritization. For example, the product manager may add a label for a new initiative to focus on for the next month and tag issues in the backlog with those labels, then area owner knows to focus on those issues.
Each feature area owner (with support from their team) will do backlog grooming by looking at the [backlog issue list](https://github.com/deephaven/deephaven-core/issues?q=is%3Aopen+milestone%3ABacklog+sort%3Areactions-%2B1-desc), breaking down issues into concise chunks with a clear definition of done, and assigning what they think they can get done in the next month. Be aware of dependencies, and work with the product manager in addition to the upvotes for prioritization. For example, the product manager may add a label for a new initiative to focus on for the next month and tag issues in the backlog with those labels, then area owner knows to focus on those issues.
2 changes: 1 addition & 1 deletion grpc-api/server/docker/gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ grpc-api-docker.baseImage=deephaven/grpc-api-base
grpc-api-docker.vendor=Deephaven Data Labs
grpc-api-docker.title=Deephaven gRPC API
grpc-api-docker.description=The Deephaven API - TODO
grpc-api-docker.source=https://github.com/deephaven/core
grpc-api-docker.source=https://github.com/deephaven/deephaven-core
grpc-api-docker.licenses=Deephaven Community License

0 comments on commit e709268

Please sign in to comment.