fix: JS API viewports should throw only for basic data issues

Network issues now fire requestfailed events to signal that the table was in a bad state. Fixes DH-18331
deephaven · Jan 8, 2025 · c1ed80f · c1ed80f
1 parent c2e715c
commit c1ed80f
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/...api/src/main/java/io/deephaven/web/client/api/subscription/TableViewportSubscription.java b/...api/src/main/java/io/deephaven/web/client/api/subscription/TableViewportSubscription.java
@@ -250,6 +250,9 @@ public void setInternalViewport(double firstRow, double lastRow, Column[] column
             Boolean isReverseViewport) {
         // Until we've created the stream, we just cache the requested viewport
         if (status == Status.STARTING) {
+            if (firstRow < 0 || firstRow > lastRow) {
+                throw new IllegalArgumentException("Invalid viewport row range: " + firstRow + " to " + lastRow);
+            }
             this.firstRow = firstRow;
             this.lastRow = lastRow;
             this.columns = columns;
@@ -273,8 +276,12 @@ public void setInternalViewport(double firstRow, double lastRow, Column[] column
             isReverseViewport = false;
         }
         RangeSet viewport = RangeSet.ofRange((long) firstRow, (long) lastRow);
-        this.sendBarrageSubscriptionRequest(viewport, Js.uncheckedCast(columns), updateIntervalMs,
-                isReverseViewport);
+        try {
+            this.sendBarrageSubscriptionRequest(viewport, Js.uncheckedCast(columns), updateIntervalMs,
+                    isReverseViewport);
+        } catch (Exception e) {
+            fireEvent(JsTable.EVENT_REQUEST_FAILED, e.getMessage());
+        }
     }
 
     /**