Skip to content

Commit

Permalink
fix: Increase timeout to almost guarantee 2 PUG cycles to eliminate r…
Browse files Browse the repository at this point in the history
…andom test failures (#6560)

random failures on the 2 test cases have been seen in CI/nightly
recently.
  • Loading branch information
jmao-denver authored Jan 13, 2025
1 parent b8f301c commit a434d62
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions py/server/tests/test_table_data_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -346,8 +346,8 @@ def test_partition_sub_failure(self):
backend.sub_new_partition_fail_test = True
table = data_service.make_table(TableKeyImpl("test"), refreshing=True)
with self.assertRaises(Exception) as cm:
# failure_cb will be called in the background thread after 2 PUG cycles
self.wait_ticking_table_update(table, 600, 2)
# failure_cb will be called in the background thread after 2 PUG cycles, 3 seconds timeout should be enough
self.wait_ticking_table_update(table, 600, 3)
self.assertTrue(table.j_table.isFailed())

def test_partition_size_sub_failure(self):
Expand All @@ -358,8 +358,8 @@ def test_partition_size_sub_failure(self):
backend.sub_partition_size_fail_test = True
table = data_service.make_table(TableKeyImpl("test"), refreshing=True)
with self.assertRaises(Exception) as cm:
# failure_cb will be called in the background thread after 2 PUG cycles
self.wait_ticking_table_update(table, 600, 2)
# failure_cb will be called in the background thread after 2 PUG cycles, 3 seconds timeout should be enough
self.wait_ticking_table_update(table, 600, 3)

self.assertTrue(table.j_table.isFailed())

Expand Down

0 comments on commit a434d62

Please sign in to comment.