Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Warmups Code Revamp #389

Merged
merged 4 commits into from
Nov 26, 2024
Merged

fix: Warmups Code Revamp #389

merged 4 commits into from
Nov 26, 2024

Conversation

stanbrub
Copy link
Collaborator

@stanbrub stanbrub commented Nov 26, 2024 •
edited
Loading

  • Warmup code had multiple issues
  • Fixed using staticFactor for incFactor
  • Moved head(<rows>) inside merge for time table benchmarks
  • Don't use head() unless warmups are active
  • Tested affected benchmarks

@stanbrub stanbrub self-assigned this Nov 26, 2024
@stanbrub stanbrub linked an issue Nov 26, 2024 that may be closed by this pull request
Warmup Change Slowed UpdateBy #388
Closed
@stanbrub stanbrub merged commit 9a7136e into deephaven:main Nov 26, 2024
3 checks passed
@stanbrub stanbrub deleted the warmup-head-issue branch November 26, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@stanbrub stanbrub

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warmup Change Slowed UpdateBy
1 participant
@stanbrub