Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Optional Benchmark Warmups #385

Merged
merged 13 commits into from
Nov 22, 2024
Merged

Conversation

stanbrub
Copy link
Collaborator

  • Added optional benchmark warmups that do a partial run of exactly the same benchmark before the measure benchmark runs
  • Tested to see nearly two thirds of JIT compile time move out of the measured operations
  • Added default warmup.row.count = 0 to release, compare, adhoc and nightly workflow files
  • Reorganized static and incremental query template generation to allow multiple runs with different row counts
  • Reworked the "read" logic to use part of the same data use for the benchmark in the warmup (eliminates two data gens)

@stanbrub stanbrub self-assigned this Nov 21, 2024
@stanbrub stanbrub linked an issue Nov 21, 2024 that may be closed by this pull request
@stanbrub stanbrub merged commit a893637 into deephaven:main Nov 22, 2024
3 checks passed
@stanbrub stanbrub deleted the optional-warmups branch November 22, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional Benchmark Warmups
1 participant