Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render reviews #1111

Merged
merged 6 commits into from
Apr 6, 2023
Merged

Render reviews #1111

merged 6 commits into from
Apr 6, 2023

Conversation

shreyalpandit
Copy link
Collaborator

Addresses Issue #1110

image

@shreyalpandit shreyalpandit requested review from avishkar58 and amritpurshotam and removed request for avishkar58 March 26, 2023 19:29
Copy link
Contributor

@avishkar58 avishkar58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Shreya!
One nice feature would be to collapse the reviews in case the admin is only interested in seeing the original response. In fact, maybe we should show the reviews at the bottom of the response, think I have a mild preference for that, definitely not a strong opinion. WDYT?

api/app/reviews/api.py Outdated Show resolved Hide resolved
api/app/reviews/api.py Outdated Show resolved Hide resolved
api/app/reviews/api.py Outdated Show resolved Hide resolved
webapp/src/pages/ResponsePage/ResponsePage.css Outdated Show resolved Hide resolved
webapp/src/pages/ResponsePage/ResponsePage.js Outdated Show resolved Hide resolved
webapp/src/pages/ResponsePage/ResponsePage.js Outdated Show resolved Hide resolved
webapp/src/pages/ResponsePage/ResponsePage.js Outdated Show resolved Hide resolved
webapp/src/pages/ResponsePage/ResponsePage.js Outdated Show resolved Hide resolved
webapp/src/pages/ResponsePage/ResponsePage.js Outdated Show resolved Hide resolved
webapp/src/pages/ResponsePage/ResponsePage.js Outdated Show resolved Hide resolved
Copy link
Contributor

@avishkar58 avishkar58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Shreya! This looks great.
Some very minor changes still left, but approving in the meantime :)

api/app/reviews/api.py Outdated Show resolved Hide resolved
api/app/reviews/api.py Show resolved Hide resolved
api/app/reviews/api.py Outdated Show resolved Hide resolved
webapp/src/pages/ResponsePage/ResponsePage.js Outdated Show resolved Hide resolved
@shreyalpandit shreyalpandit merged commit d7ccb42 into develop Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants