Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: introduce some variation in element background colors #2601

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

buck54321
Copy link
Member

@buck54321 buck54321 commented Nov 10, 2023

This is an alternative to #2588. Some features

  • As in ui: Dialog panel coloring #2588, this introduces some new colors to break the visual monotony of the current layout.
  • The header is a slightly darker color in light mode and a slightly lighter color in dark mode.
  • Form elements get the same treatment, along with drop shadows. In dark mode, form elements get a light border.
  • The #forms element gets just a little background transparency.
  • A distinction is made between the init / login / register view, where the header is not hidden by the #forms element, and all other views, where it is.
  • It may not be immediately noticeable, but the background color in light mode is tuned down just a bit. Pure white was kind of aggressive.
  • New colors are used sparingly in non-form views.

Registration / Login

image

image

Forms on the wallets view

image

image

Wallets

image

image

Markets

image

image

@buck54321 buck54321 changed the title introduce some variation in element background colors ui: introduce some variation in element background colors Nov 10, 2023
@peterzen
Copy link
Member

Registration / Login

image

image

The modals look very nice and polished.

Markets

image

image

The borders don't represent the visual hierarchy; the lines between the 4 main columns have the same appearance as the grid in the charts, the separators in the left and right columns and even the border of the asset search field. If they are meant to represent the grouping of the elements a few different colors/widths would have to be used.

@peterzen
Copy link
Member

image

Maybe take the opacity of the inactive tab down a notch?

@peterzen
Copy link
Member

peterzen commented Nov 11, 2023

On a more general note, not strictly within the scope of this PR but related - the main call to action submit buttons (Create BTC wallet, Create account) could use some accent, i.e. background color.

image

The subsection titles and the buttons have similar appearance.

@buck54321 buck54321 merged commit 7d11d2c into decred:master Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants