Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: disk cache disable via args #3260

Open
wants to merge 15 commits into
base: dev
Choose a base branch
from
Open

Conversation

NickKhalow
Copy link
Contributor

@NickKhalow NickKhalow commented Jan 30, 2025

What does this PR change?

Adds --disable-disk-cache flag to disable disk cache on launch
Adds --disable-disk-cache-cleanup flag to disable LRU disk cleanup on launch

Adds limitation of the content size for NFTS
...

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

@NickKhalow NickKhalow requested review from a team as code owners January 30, 2025 17:43
@NickKhalow NickKhalow self-assigned this Jan 30, 2025
@Ludmilafantaniella
Copy link

I tested this feature on Mac with the following scenarios:

Scenario 1 – Testing with the --disable-disk-cache flag enabled

  • Launched the Explorer with the flag.
  • Performed teleports to the following scenes, always starting from Genesis Plaza (0,0) (teleported, returned to Genesis Plaza, and teleported again):

Scenes tested:

  • Metagamimall
  • Wondermine
  • Soul Magic
  • Butterfly Prawn Farming
  • Doll House
  • The Inn
  • Casa Roustan
  • Franky's Tavern
  • Game Expo
  • Music Festival
  • AR Week
  • World Metdaynelabs

Result:
✅ I did 24 teleports without any issues; the loading screen progressed smoothly and quickly.

Scenario 2 – Testing without the flag

  • Repeated the same teleport sequence without the feature flag.
  • Result: Got stuck at 20% on the 12th teleport.

Player.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants