-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: update 'external URL' copies and add buttons animations #3251
Conversation
Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix implemented on both platforms ! ✅
PR check on windows :
- Discord modal New UI ✅
- X modal New UI ✅
✅ the checkbox is working.
✅ Continue button is currently working
✅ Cancel button is currently working
Sanity check made on this PR :
- Teleport (Dollhouse/ the inn / Metadynelabs)
- Profile customization
- Camera functionality
- Gallery
- Map functionality
- Backpack
- Skybox
- Emotes
PR check on macos :
- Discord modal New UI ✅
- X modal New UI ✅
✅ the checkbox is working.
✅Continue button is currently working
✅ Cancel button is currently working
Sanity check done on this PR:
- Profile customization
- Backpack
- Teleport : dollhouse / the inn / metadynelabs
- Badges
- Notifications
- Skybox
- map functionality
- Emotes
- camera functionality / Gallery
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix implemented on both platforms ! ✅
PR check on windows :
- Discord modal New UI ✅
- X modal New UI ✅
✅ the checkbox is working.
✅ Continue button is currently working
✅ Cancel button is currently working
Sanity check made on this PR :
- Teleport (Dollhouse/ the inn / Metadynelabs)
- Profile customization
- Camera functionality
- Gallery
- Map functionality
- Backpack
- Skybox
- Emotes
PR check on macos :
- Discord modal New UI ✅
- X modal New UI ✅
✅ the checkbox is working.
✅Continue button is currently working
✅ Cancel button is currently working
Sanity check done on this PR:
- Profile customization
- Backpack
- Teleport : dollhouse / the inn / metadynelabs
- Badges
- Notifications
- Skybox
- map functionality
- Emotes
- camera functionality / Gallery
What does this PR change?
This PR updates the copies of the modal and add the missing animations on the buttons. Additionally, the checkmark container asset changed for a white squared instead of a transparent one.
Observe that the 'domain' text field has been remove leaving the link visible only.
BEFORE
![Screenshot 2025-01-29 at 15 27 00](https://private-user-images.githubusercontent.com/51088292/407875068-e76f293b-c7e7-408f-ae1c-67eb37c2184a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwNjg3NzcsIm5iZiI6MTczOTA2ODQ3NywicGF0aCI6Ii81MTA4ODI5Mi80MDc4NzUwNjgtZTc2ZjI5M2ItYzdlNy00MDhmLWFlMWMtNjdlYjM3YzIxODRhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA5VDAyMzQzN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTUzNzU3MTk2NGViN2NjNzk0ZjkyMWVmNjI3M2YwYTZkOWRlNDFkY2IxYmIzYzRkYzFlOGJhM2E5NDlmN2FhNjMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.PfWgaaYxkyS09L7FsyiSJQy9qeOEgu8Ek4YAas0xmAg)
AFTER
![Screenshot 2025-01-29 at 17 26 26](https://private-user-images.githubusercontent.com/51088292/407896691-c0ccd7e0-8ce4-4218-98dd-f2ce6595d6f8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwNjg3NzcsIm5iZiI6MTczOTA2ODQ3NywicGF0aCI6Ii81MTA4ODI5Mi80MDc4OTY2OTEtYzBjY2Q3ZTAtOGNlNC00MjE4LTk4ZGQtZjJjZTY1OTVkNmY4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA5VDAyMzQzN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTgzY2U1YjU5ODJkNzFiZmU3YTU2NWUyMTA2OWJmYTEzZDE4NGU5MTc3Nzk5YTQ0MzE0MWZlODU0MTg4ODZhMGUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.88njWVQxANCaMZMPPxbbMUI1NYzFn2N8VLx-5nPF1nI)
How to test the changes?