Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: update 'external URL' copies and add buttons animations #3251

Merged
merged 4 commits into from
Feb 3, 2025

Conversation

RominaMarchetti
Copy link
Contributor

@RominaMarchetti RominaMarchetti commented Jan 29, 2025

What does this PR change?

This PR updates the copies of the modal and add the missing animations on the buttons. Additionally, the checkmark container asset changed for a white squared instead of a transparent one.
Observe that the 'domain' text field has been remove leaving the link visible only.

BEFORE
Screenshot 2025-01-29 at 15 27 00

AFTER
Screenshot 2025-01-29 at 17 26 26

How to test the changes?

  1. Launch the explorer.
  2. To open the modal, click the 'Discord' or 'X' buttons located at the spawn point platform in Genesis Plaza. Validate the hover/press animation is working in both main buttons.
  3. Check the checkbox container has been updated with the correct white style.

@RominaMarchetti RominaMarchetti requested review from a team as code owners January 29, 2025 19:21
Copy link

@DafGreco DafGreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix implemented on both platforms ! ✅

PR check on windows :

  • Discord modal New UI ✅
  • X modal New UI ✅

✅ the checkbox is working.
✅ Continue button is currently working
✅ Cancel button is currently working

Sanity check made on this PR :

  • Teleport (Dollhouse/ the inn / Metadynelabs)
  • Profile customization
  • Camera functionality
  • Gallery
  • Map functionality
  • Backpack
  • Skybox
  • Emotes

PR check on macos :

  • Discord modal New UI ✅
  • X modal New UI ✅

✅ the checkbox is working.
✅Continue button is currently working
✅ Cancel button is currently working

Sanity check done on this PR:

  • Profile customization
  • Backpack
  • Teleport : dollhouse / the inn / metadynelabs
  • Badges
  • Notifications
  • Skybox
  • map functionality
  • Emotes
  • camera functionality / Gallery

Before this fix :
image

After the fix has been implemented :
image

Copy link

@DafGreco DafGreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix implemented on both platforms ! ✅

PR check on windows :

  • Discord modal New UI ✅
  • X modal New UI ✅

✅ the checkbox is working.
✅ Continue button is currently working
✅ Cancel button is currently working

Sanity check made on this PR :

  • Teleport (Dollhouse/ the inn / Metadynelabs)
  • Profile customization
  • Camera functionality
  • Gallery
  • Map functionality
  • Backpack
  • Skybox
  • Emotes

PR check on macos :

  • Discord modal New UI ✅
  • X modal New UI ✅

✅ the checkbox is working.
✅Continue button is currently working
✅ Cancel button is currently working

Sanity check done on this PR:

  • Profile customization
  • Backpack
  • Teleport : dollhouse / the inn / metadynelabs
  • Badges
  • Notifications
  • Skybox
  • map functionality
  • Emotes
  • camera functionality / Gallery

Before this fix :
image

After the fix has been implemented :
image

@RominaMarchetti RominaMarchetti requested review from davidejensen, fcolarich and lorux0 and removed request for dalkia and NickKhalow January 31, 2025 19:50
@m3taphysics m3taphysics merged commit ca774d3 into dev Feb 3, 2025
12 of 18 checks passed
@m3taphysics m3taphysics deleted the style/url-modal-update-copy-and-animations branch February 3, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants