Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: friend requests ui #3188

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

feat: friend requests ui #3188

wants to merge 12 commits into from

Conversation

lorux0
Copy link
Collaborator

@lorux0 lorux0 commented Jan 22, 2025

What does this PR change?

Integrates the friend requests UI so it can be shown whenever a friend request needs to be represented either by:

  • send new
  • cancel existent
  • receive accept/reject

Here are some examples on how the UI can be displayed:

// Send new
await mvcManager.ShowAsync(FriendRequestController.IssueCommand(new FriendRequestParams
    {
        DestinationUser = new Web3Address("0xc9c29ab98e6bc42015985165a11153f564e9f8c2"),
    }), ct);

// Show existent
await mvcManager.ShowAsync(FriendRequestController.IssueCommand(new FriendRequestParams
    {
        Request = new FriendRequest(Guid.NewGuid().ToString(), DateTime.UtcNow,
            // One of these addresses should be our own user address
            "0x...",
            "0x...",
            "Custom Message"),
    }), ct);

How to test the changes?

  1. Launch the explorer
  2. Check that the startup flows works as expected

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

@lorux0 lorux0 requested review from a team as code owners January 22, 2025 21:10
# Conflicts:
#	Explorer/Assets/AddressableAssetsData/AssetGroups/Essentials.asset
#	Explorer/Assets/DCL/Friends/DCL.Friends.asmdef
#	Explorer/Assets/DCL/PluginSystem/Global/Global Plugins Settings.asset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants