Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/outlinetransparents #3184

Merged
merged 3 commits into from
Jan 22, 2025
Merged

fix/outlinetransparents #3184

merged 3 commits into from
Jan 22, 2025

Conversation

GBirch33
Copy link
Collaborator

Fixes outline affecting transparents.

@GBirch33 GBirch33 requested review from a team as code owners January 22, 2025 11:17
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 22, 2025 •
edited
Loading

badge

Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below.

Name Link
Commit 0d89609
Logs https://github.com/decentraland/unity-explorer/actions/runs/12908610372
Download Windows https://github.com/decentraland/unity-explorer/suites/33373019893/artifacts/2468029451
Download Windows S3 https://explorer-artifacts.decentraland.org/@dcl/unity-explorer/branch/fix/outlinetransparents/Decentraland_windows64.zip
Download Mac https://github.com/decentraland/unity-explorer/suites/33373019893/artifacts/2468452818
Download Mac S3 https://explorer-artifacts.decentraland.org/@dcl/unity-explorer/branch/fix/outlinetransparents/Decentraland_macos.zip
Built on 2025-01-22T14:37:07Z

@aixaCode aixaCode changed the base branch from dev to release/release-21-01-2025 January 22, 2025 11:32
@dalkia dalkia force-pushed the fix/outlinetransparents branch from 8b23612 to 0acaa81 Compare January 22, 2025 12:08
anicalbano
anicalbano approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@anicalbano anicalbano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Checked on Windows and Mac and working as expected.
The test was made with different wearables and same results:

image
image

@dalkia dalkia merged commit 61378a1 into release/release-21-01-2025 Jan 22, 2025
9 checks passed
@dalkia dalkia deleted the fix/outlinetransparents branch January 22, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anicalbano anicalbano anicalbano approved these changes

@dalkia dalkia dalkia approved these changes

@DafGreco DafGreco Awaiting requested review from DafGreco

@mikhail-dcl mikhail-dcl Awaiting requested review from mikhail-dcl

@popuz popuz Awaiting requested review from popuz

Assignees

@GBirch33 GBirch33

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GBirch33 @dalkia @anicalbano