chore: moved environment selection to EntryPoint #3183
Merged
+22
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below. |
github-actions
bot
requested review from
anicalbano,
mikhail-dcl and
pravusjif
dalkia
approved these changes
Jan 22, 2025
QThund
approved these changes
Jan 22, 2025
DafGreco
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Windows check login :
- Jump in with an already logged in account ✅
- Create a new account✅
- Log in with one account , Log out and then log in with another account ✅
Sanity check performed :
- log in/Log out ✅
- On boarding & rewards✅
- Quests & rewards✅
- Teleport : Dollhouse / the inn / Metadynelabs ✅
- Map ✅
- Notifications ✅
- Camera functionality ✅
- Backpack✅
Macos check login
- Jump in with an already logged in account ✅
- Create a new account ✅
- Log in with one account , Log out and then log in with another account ✅
Sanity check on macos:
- On boarding and rewards ✅
- Login/Logout✅
- Badges ✅
- Camera functionality✅
- Teleport✅ : dollhouse /the inn/metadynelabs
- Backpack ✅
- Emotes ✅
- Settings ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Moves the environment dropdown from an inner config to the EntryPoint
...
How to test the changes?
Just a quick smoke test that login works fine
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md