resolve DynamicWorldContainer #3022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
fcolarich,
Ludmilafantaniella and
mikhail-dcl
|
New build in progress, come back later! |
# Conflicts: # Explorer/Assets/DCL/PerformanceAndDiagnostics/Analytics/Systems/AnalyticsPlugin.cs # Explorer/Assets/Scripts/Global/Dynamic/DynamicWorldContainer.cs
Ludmilafantaniella
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
🟢 Smoke test performed on both mac and windows covering:
- Login
- Quest progression (Salad Slash, Memory Circus)
- Social interactions (chats, passport, emotes sync)
- Teleport using the GP carrousel, map and chat commands
- Scene/world visited: Casa Roustan, Olavra, Metadynelabs, Exodus
- Backpack - wreables and emotes
- Emote wheel
- Sidebar shortcuts
# Conflicts: # Explorer/Assets/Scripts/Global/Dynamic/DynamicWorldContainer.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Solved issue:
It's possible to pass an uninitialized dependency to an object that requires it. For example, you might pass container.ChatMessagesBus, assuming it's initialized, but in reality, it's only initialized dozens of lines later. This can lead to a null reference error in a completely different part of the code due to the invalid dependency.
To solve this, I propose to make DynamicWorldContainer immutable and construct it only at the return steps. This approach will prevent such issues at compile time by ensuring that references cannot be passed before they are initialized.
How to test the changes?
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md