fix: logout flow #3018
Merged
fix: logout flow #3018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New build in progress, come back later! |
Ludmilafantaniella
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
QA Approved ✅
Tested on Windows and Mac:
- Verified logout and login functionality.
- Confirmed the fix for ticket [QA] Explorer kicks out a player to the main screen after logging in and out with different accounts #2990.
- Used 4 different accounts (Google, Metamask, Discord, X) to log in on both platforms within the same session.
Everything is working as expected. No issues found.
Untitled.Video.-.Made.With.Clipchamp.mp4
Smoke test performed:
- Passport of each account
- Backpack of each account
- Emotes functionality
- Teleport: The Inn, Casa Roustan, Metadynelabs, Pravus, DollHouse
- Quests --> minigames mission completition
- Multiplayer (chat, emotes, passport)
|
🟢 Rechecked: Same tests were performed on Windows and Mac. I found a minor bug where quest pins from the previous account appear on the map along with the current ones. The team decided to fix this in a separate ticket as it’s not a blocker. No similar issues were found in the backpack, emotes wheel, or other areas. quest.logoutin.mp4 |
NickKhalow
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Fixes #2530
Fixes #2990
RestartRealmStartupOperationsince it didn't seem necessaryHow to test the changes?
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md