Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: camera reel - navmap integration #3011

Merged

Conversation

lorenzo-ranciaffi
Copy link
Contributor

@lorenzo-ranciaffi lorenzo-ranciaffi commented Dec 16, 2024

What does this PR change?

Implements the place gallery into the appropriate navmap section, showing all public reels taken in a specific place.

How to test the changes?

  1. Launch the explorer with all reels base urls pointing to zone
  2. Open the navmap
  3. Click on a parcel
  4. Switch to the PHOTOS section
  5. Click on any reels and verify it opens the photo detail view

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

@lorenzo-ranciaffi lorenzo-ranciaffi self-assigned this Dec 16, 2024
Copy link
Contributor

badge

New build in progress, come back later!

@lorenzo-ranciaffi lorenzo-ranciaffi added the no QA needed Used to tag pull requests that does not require QA validation label Dec 16, 2024
@lorenzo-ranciaffi lorenzo-ranciaffi marked this pull request as ready for review December 16, 2024 16:01
@davidejensen davidejensen merged commit 40c440e into feat/map-discoverability Dec 16, 2024
@davidejensen davidejensen deleted the feat/map_discoverability/place-reels branch December 16, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no QA needed Used to tag pull requests that does not require QA validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants