Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: camera reel - passport integration #2962

Merged
merged 176 commits into from
Dec 16, 2024
Merged

Feat: camera reel - passport integration #2962

merged 176 commits into from
Dec 16, 2024

Conversation

lorenzo-ranciaffi
Copy link
Contributor

@lorenzo-ranciaffi lorenzo-ranciaffi commented Dec 9, 2024 •
edited
Loading

What does this PR change?

Fix #2961

Implements the "public" reel gallery in player's passport by adding a new "Photos" tab where every player's reel flagged as public is visible to other players.
Also adds analytics for reel interactions and prepares the gallery for places.

How to test the changes?

  1. Launch the explorer with the CLI arg camera-reel, dclenv zone and debug flags
  2. Open the passport of a player and check that every reel flagged as public is visible and not editable
  3. The passport can be either another player's or your own
  4. By clicking any reel, the photo detail popup gets opened

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

lorenzo-ranciaffi and others added 30 commits October 29, 2024 14:13
@lorenzo-ranciaffi
camera reel explore panel section - wip
b174212
@lorenzo-ranciaffi
Merge branch 'dev' into feat/camera-reel/gallery-ui
21af0c2 
# Conflicts:
#	Explorer/Assets/DCL/Input/UnityInputSystem/DCLInput.cs
#	Explorer/Assets/DCL/Input/UnityInputSystem/DCLInput.inputactions
@lorenzo-ranciaffi
working camera reel panel
55f231c
@lorenzo-ranciaffi
storage full toast message implementation
630b046
@lorenzo-ranciaffi
Merge branch 'dev' into feat/camera-reel/gallery-ui
b5f82d7
@lorenzo-ranciaffi
import all image assets + no photo background
395a6aa
@lorenzo-ranciaffi
fix text colors
f1ab266
@lorenzo-ranciaffi
wip prefabs
b233178
@lorenzo-ranciaffi
Merge branch 'dev' into feat/camera-reel/gallery-ui
20b68de 
# Conflicts:
#	Explorer/Assets/DCL/PluginSystem/DCL.Plugins.asmdef
@lorenzo-ranciaffi
wip reel layout
41f7fa1
@lorenzo-ranciaffi
Merge branch 'dev' into feat/camera-reel/gallery-ui
a98f56f 
# Conflicts:
#	Explorer/Assets/DCL/InWorldCamera.meta
@lorenzo-ranciaffi
wip working reel menu
248b32c
@lorenzo-ranciaffi
modified services and instantiated them in dynamic container + galler…
d676f1a 
…y layout structure (wip logic)
@lorenzo-ranciaffi
fix gallery presentation
db879f2
@lorenzo-ranciaffi
wip fetch all data
a4d7b09
@lorenzo-ranciaffi
fix layout + all pooled
4281e2e
@lorenzo-ranciaffi
wip - context menu
3d344d9
@lorenzo-ranciaffi
set option button listener via code
b92d820
@lorenzo-ranciaffi
fix thumbnail context menu visibility
1b41a33
@lorenzo-ranciaffi
fix thumbnail loading mask + mock "isPublic" property on image
bf0ef95
@lorenzo-ranciaffi
paginated scroll view
72927c1
@lorenzo-ranciaffi
fix thumbnail prefab
1bd68ff
@RominaMarchetti
Fix photo loading mask and colours
2189b93
@RominaMarchetti
Fix anchors of the 'StorageProgressBar' UI elements
a86a363
@RominaMarchetti
Update 'MonthGrid' font style
2ede3b0
@RominaMarchetti
Polish context menu UI
79607ef
@RominaMarchetti
Textures housekeeping
08f855a
@lorenzo-ranciaffi
fix loading + cache sprites
af80c43
@lorenzo-ranciaffi
Merge branch 'feat/camera-reel/gallery-ui' of github.com:decentraland…
6d2bc30 
…/unity-explorer into feat/camera-reel/gallery-ui
@lorenzo-ranciaffi
fix fade in on loading
17008b5
lorenzo-ranciaffi and others added 15 commits December 10, 2024 16:12
@lorenzo-ranciaffi
fix gallery success notification message visuals
1b18bd8
@lorenzo-ranciaffi
fix thumbnail loading leak
4acb053
@lorenzo-ranciaffi
add place reels endpoint
0e62bc4
@lorenzo-ranciaffi
introduce place reel gallery fetching logic
09b684c
@lorenzo-ranciaffi
fix passport reel scroll bar
e697e5a
@lorenzo-ranciaffi
Merge branch 'dev' into feat/camera-reel/passport-integration
4606284 
# Conflicts:
#	Explorer/Assets/AddressableAssetsData/Windows/addressables_content_state.bin.meta
#	Explorer/Assets/DCL/AvatarRendering/Wearables/IWearablesProvider.cs
#	Explorer/Assets/DCL/InWorldCamera/CameraReelGallery/Assets/CameraReel.prefab
#	Explorer/Assets/DCL/InWorldCamera/CameraReelGallery/Assets/CameraReelGallery.prefab
#	Explorer/Assets/DCL/InWorldCamera/CameraReelGallery/Assets/ThumbnailElement.prefab
#	Explorer/Assets/DCL/InWorldCamera/CameraReelGallery/CameraReelGalleryController.cs
#	Explorer/Assets/DCL/InWorldCamera/CameraReelGallery/Components/ReelThumbnailController.cs
#	Explorer/Assets/DCL/InWorldCamera/CameraReelStorageService/CameraReelRemoteStorageService.cs
#	Explorer/Assets/DCL/InWorldCamera/PassportBridge.meta
#	Explorer/Assets/DCL/InWorldCamera/PhotoDetail.meta
#	Explorer/Assets/DCL/InWorldCamera/PhotoDetail/EquippedWearableController.cs
#	Explorer/Assets/DCL/InWorldCamera/PhotoDetail/PhotoDetail.asmdef
#	Explorer/Assets/DCL/InWorldCamera/PhotoDetail/PhotoDetailController.cs
#	Explorer/Assets/DCL/InWorldCamera/PhotoDetail/PhotoDetailInfoController.cs
#	Explorer/Assets/DCL/InWorldCamera/PhotoDetail/PhotoDetailInfoView.cs
#	Explorer/Assets/DCL/InWorldCamera/PhotoDetail/PhotoDetailParameter.cs
#	Explorer/Assets/DCL/InWorldCamera/PhotoDetail/PhotoDetailPoolManager.cs
#	Explorer/Assets/DCL/InWorldCamera/PhotoDetail/PhotoDetailUtility.cs
#	Explorer/Assets/DCL/InWorldCamera/PhotoDetail/PhotoDetailView.cs
#	Explorer/Assets/DCL/InWorldCamera/PhotoDetail/VisiblePersonController.cs
#	Explorer/Assets/DCL/InWorldCamera/ReelActions/ReelActions.asmdef
#	Explorer/Assets/DCL/InWorldCamera/ReelActions/ReelCommonActions.cs
#	Explorer/Assets/DCL/InWorldCamera/ReelActions/ReelUtility.cs
#	Explorer/Assets/DCL/PluginSystem/DCL.Plugins.asmdef
#	Explorer/Assets/DCL/PluginSystem/Global/Global Plugins Settings.asset
#	Explorer/Assets/DCL/PluginSystem/Global/InWorldCameraPlugin.cs
@lorenzo-ranciaffi
re-enabled month text in passport gallery
568ae3b
@lorenzo-ranciaffi
wip photo detail analytics
d343aa7
@lorenzo-ranciaffi
jump to market analytics in photo detail view
832056b
@lorenzo-ranciaffi
fix addressables + delete analytic
e1dc51a
@lorenzo-ranciaffi
fix reel deletion edge case
06bd82f
@lorenzo-ranciaffi
fix pending action on disable
6815d7b
@lorenzo-ranciaffi
added missing analytics
7963218
@lorenzo-ranciaffi
added class comment
3acfab7
@lorenzo-ranciaffi
Merge branch 'dev' into feat/camera-reel/passport-integration
8e33f42
@lorenzo-ranciaffi lorenzo-ranciaffi marked this pull request as ready for review December 13, 2024 15:00
fcolarich
fcolarich approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@fcolarich fcolarich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a couple of comments with suggestions but nothing mandatory, it looks good from my side 😁

davidejensen
davidejensen approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@davidejensen davidejensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, approved with some minor suggestions

Explorer/Assets/DCL/InWorldCamera/CameraReelGallery/CameraReelController.cs Outdated Show resolved Hide resolved
Explorer/Assets/DCL/InWorldCamera/CameraReelGallery/CameraReelGalleryController.cs Outdated Show resolved Hide resolved
Explorer/Assets/DCL/InWorldCamera/CameraReelGallery/CameraReelGalleryController.cs Show resolved Hide resolved
Explorer/Assets/DCL/InWorldCamera/PassportBridge/IPassportBridge.cs Show resolved Hide resolved
Explorer/Assets/DCL/InWorldCamera/PhotoDetail/EquippedWearableController.cs Show resolved Hide resolved
Explorer/Assets/DCL/InWorldCamera/ReelActions/ReelCommonActions.cs Outdated Show resolved Hide resolved
Explorer/Assets/DCL/Passport/PassportController.cs Outdated Show resolved Hide resolved
@lorenzo-ranciaffi lorenzo-ranciaffi merged commit 349917c into dev Dec 16, 2024
2 of 4 checks passed
@lorenzo-ranciaffi lorenzo-ranciaffi deleted the feat/camera-reel/passport-integration branch December 16, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcolarich fcolarich fcolarich approved these changes

@davidejensen davidejensen davidejensen approved these changes

@DafGreco DafGreco Awaiting requested review from DafGreco

@lorux0 lorux0 Awaiting requested review from lorux0

@mikhail-dcl mikhail-dcl Awaiting requested review from mikhail-dcl

Assignees

@lorenzo-ranciaffi lorenzo-ranciaffi

Labels
clean-build Used to trigger clean build on PR force-build Used to trigger a build on draft PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: camera reel - passport integration
5 participants
@lorenzo-ranciaffi @davidejensen @fcolarich @popuz @RominaMarchetti