Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: loading multiple pxs at start time issues #2847

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

fcolarich
Copy link
Contributor

What does this PR change?

SO, we were reusing the ServerAbout and it caused (when loading multiple PXs without delay) to sometimes load the wrong scenes for one of the PXs...
This is fixed now.
...

How to test the changes?

Open the client, it should load the PXs correctly and track the progress of the MF quests correctly as well.

@DafGreco DafGreco self-requested a review November 21, 2024 10:33
Copy link

@DafGreco DafGreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey team ! Fix verified on both platforms ! UI appears properly on windows and macos ✅

This PR only fixes the missing UI from a user perspective but does not fix the progress tracking issue that we are currently having.

@m3taphysics m3taphysics merged commit 65013f6 into dev Nov 21, 2024
6 checks passed
@m3taphysics m3taphysics deleted the fix/loading_multiple_pxs_nono branch November 21, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants