Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added remote player pins #2841

Merged
merged 4 commits into from
Nov 21, 2024
Merged

feat: added remote player pins #2841

merged 4 commits into from
Nov 21, 2024

Conversation

davidejensen
Copy link
Member

What does this PR change?

This PR adds the remote player markers in the map

...

How to test the changes?

  1. Launch the explorer
  2. Open the map
  3. Verify you see the red circle indicating players around the map even far from you
  4. The far player position is updated only when toggling on and off the player layer or teleporting

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

@davidejensen davidejensen self-assigned this Nov 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 20, 2024 •
edited
Loading

badge

New build in progress, come back later!

DafGreco
DafGreco reviewed Nov 20, 2024
View reviewed changes
Copy link

@DafGreco DafGreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Windows and Macos ! ✅ Working as expected

@davidejensen davidejensen merged commit 5d2456f into feat/map-discoverability Nov 21, 2024
1 of 4 checks passed
@davidejensen davidejensen deleted the feat/far-player-markers branch November 21, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DafGreco DafGreco DafGreco left review comments

@lorux0 lorux0 lorux0 requested changes

@fcolarich fcolarich Awaiting requested review from fcolarich

Assignees

@davidejensen davidejensen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidejensen @lorux0 @DafGreco