feat: improvements and fixes on places and events panel #2834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New build in progress, come back later! |
davidejensen
approved these changes
Nov 20, 2024
|
|
||
| view.CollapseButton.gameObject.SetActive(true); | ||
| view.ExpandButton.gameObject.SetActive(false); | ||
| view.CollapseButton.onClick.AddListener(Collapse); | ||
| view.ExpandButton.onClick.AddListener(Expand); | ||
|
|
||
| view.PointerEnter += DisableMapZoom; | ||
| view.PointerExit += EnableMapZoom; |
There was a problem hiding this comment.
can you unsub in the dispose?
There was a problem hiding this comment.
Do you find it necessary? This controller is just created once during the whole lifecycle of the app and i dont see that is going to change
dalkia
approved these changes
Nov 20, 2024
…overability-placesnevents-improvements # Conflicts: # Explorer/Assets/DCL/PluginSystem/Global/ExplorePanelPlugin.cs
lorux0
deleted the
feat/map-discoverability-placesnevents-improvements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md