Make sure all instances of PartitionComponent come from the pool #2833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below.
|
github-actions
bot
requested review from
Ludmilafantaniella,
mikhail-dcl and
NickKhalow
mikhail-dcl
approved these changes
Nov 20, 2024
Explorer/Assets/Scripts/ECS/SceneLifeCycle/Components/VolatileScenePointers.cs
Show resolved
Hide resolved
DafGreco
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Make sure all instances of PartitionComponent come from the pool and return to it. This fixes a memory leak where VolatileScenePointers creates a new instance of PartitionComponent instead of taking one from the pool, and then later ReleaseReferenceComponentsSystem adds it to the pool. The pool receives components it did not create and grows endlessly.
Unit tests are exempt.
This change is one part of a series of changes to address #2694. It is turning out to be such a rabbit hole, so I'm splitting my work up into multiple pull requests.
How to test the changes?
The game should behave exactly the same as without this change.
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md