Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 11-4-2024 #2705

Merged
merged 24 commits into from
Nov 4, 2024
Merged

release: 11-4-2024 #2705

merged 24 commits into from
Nov 4, 2024

Conversation

m3taphysics
Copy link
Collaborator

What does this PR change?

...

How to test the changes?

  1. Launch the explorer
  2. ...

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

dalkia and others added 24 commits October 24, 2024 15:07
* fix: update audio for streams with no volume set

* minor fix
* fixed mime header for video streams

* Minor changes to query param condition

* Minor comment addition
* Make tween update the transform as well as the SDK value and update after transform update as well

* Update TweenUpdaterSystem.cs

* Fixed tween

* Streamlined tweens logic

* Update TweenSDKComponentHelper.cs
* fix: attempt to remove build id

Signed-off-by: Ashley Canning <[email protected]>

* Update build.py

Signed-off-by: Ashley Canning <[email protected]>

* Update build.py

Signed-off-by: Ashley Canning <[email protected]>

* Update build.py

Signed-off-by: Ashley Canning <[email protected]>

* Update build.py

Signed-off-by: Ashley Canning <[email protected]>

---------

Signed-off-by: Ashley Canning <[email protected]>
Signed-off-by: Ashley Canning <[email protected]>
Signed-off-by: Ashley Canning <[email protected]>
Co-authored-by: Juan Ignacio Molteni <[email protected]>
Co-authored-by: Ashley Canning <[email protected]>
* Turned off maskable feature for tooltip

* Decrease progress bar width. Increase progress text box size.

* Turned of mask feature for the tooltip text

---------

Co-authored-by: Ashley Canning <[email protected]>
## What does this PR change?

Adds infrastructure layer for connecting with the Camera Reel backend to Get/Delete/Upload screenshots with their metadata. Currently working only GET request (others are Unauthorized and will be solved it on the back end side)
Copy link
Contributor

github-actions bot commented Nov 4, 2024

@anicalbano anicalbano self-requested a review November 4, 2024 16:53
Copy link
Contributor

@anicalbano anicalbano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Reviewed by QA and approved following our smoke test standars on Notion for both Windows and Mac:

https://www.notion.so/decentraland/Smoke-Test-Alpha-1055f41146a58020a624e86a564d60a1

We found an issue for login, but it's and edge case that doesn't block the process. A ticket will be created to follow up.

@m3taphysics m3taphysics added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit 89da81b Nov 4, 2024
61 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.