Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sdk7 eth provider #253

Merged
merged 7 commits into from
Jan 11, 2024
Merged

Conversation

lorux0
Copy link
Collaborator

@lorux0 lorux0 commented Jan 9, 2024

Adds the possibility for scenes from the sdk to request ethereum transactions following EthereumController.sendAsync specification, which will result in a schema equivalent to:

{
    "id": number,
    "jsonrpc": "2.0",
    "result": the raw data from https://docs.metamask.io/wallet/reference/json-rpc-api/
}

@lorux0 lorux0 marked this pull request as ready for review January 10, 2024 18:56
@lorux0 lorux0 requested a review from mikhail-dcl January 10, 2024 18:57
Copy link
Contributor

badge

Windows build successfull! You can find a link to the downloadable artifact below.

Name Link
Commit 974016f
Logs https://github.com/decentraland/unity-explorer/actions/runs/7479521738
Download https://github.com/decentraland/unity-explorer/suites/19679386023/artifacts/1160470713

Copy link
Collaborator

@mikhail-dcl mikhail-dcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All my concerns were addressed. 💪 Thank you

@mikhail-dcl mikhail-dcl merged commit fdea725 into feat/sign-messages-dapp Jan 11, 2024
2 checks passed
@mikhail-dcl mikhail-dcl deleted the feat/sdk7-eth-provider branch January 11, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants