Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FrameTimeCapBudget to ulong #252

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Conversation

NickKhalow
Copy link
Contributor

Currently DCL.Optimization.PerformanceBudgeting.FrameTimeCapBudget deals with float values that can lead to loss of precision and may cause unexpected behaviour. it have been replaced with ulong value

@NickKhalow NickKhalow linked an issue Jan 9, 2024 that may be closed by this pull request
@NickKhalow NickKhalow requested a review from popuz January 9, 2024 15:10
@NickKhalow NickKhalow enabled auto-merge (squash) January 9, 2024 15:10
Copy link
Contributor

github-actions bot commented Jan 9, 2024

badge

Windows build successfull! You can find a link to the downloadable artifact below.

Name Link
Commit 19a80cc
Logs https://github.com/decentraland/unity-explorer/actions/runs/7475721642
Download https://github.com/decentraland/unity-explorer/suites/19668577677/artifacts/1159600723

@mikhail-dcl mikhail-dcl added the no QA needed Used to tag pull requests that does not require QA validation label Jan 10, 2024
@NickKhalow NickKhalow merged commit 6c274c3 into main Jan 10, 2024
3 checks passed
@NickKhalow NickKhalow deleted the chore/frametimecapbudget-float-issue branch January 10, 2024 14:54
Kinerius pushed a commit that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no QA needed Used to tag pull requests that does not require QA validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FrameTimeCapBudget float issue
2 participants