refactor: performance budgeting #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IConcurrentBudgetProvider -> IReleasablePerformanceBudget
github-actions
bot
requested review from
anicalbano,
mikhail-dcl and
sandrade-dcl
popuz
requested changes
Jan 8, 2024
There was a problem hiding this comment.
Most clients using only TrySpend method, so they can rely on IPerformanceBudget interface instead of IReleasablePerformanceBudget. I commented one case, but please check it in all other clients.
Same probably true for IReleasablePerformanceBudget, where client only uses TryRelease method, but this one is up to you if you want to refactor it further
...er/Assets/Scripts/ECS/Unity/PrimitiveRenderer/Systems/InstantiatePrimitiveRenderingSystem.cs
Outdated
Show resolved
Hide resolved
popuz
approved these changes
Jan 9, 2024
# Conflicts: # Explorer/Assets/DCL/PluginSystem/World/TextShapePlugin.cs
|
Windows build successfull! You can find a link to the downloadable artifact below.
|
Kinerius
pushed a commit
that referenced
this pull request
Feb 20, 2024
* IReadOnlyDictionary for memoryThreshold * Introduced PerformanceBudget IConcurrentBudgetProvider -> IReleasablePerformanceBudget * replace usage to IPerformanceBudget
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous contract there was many implementations that violates LSP with empty method that ignores call. To get rid off it here is introduced:
PerformanceBudget that allows only spend a budget. Also according on the concern that object solves it was renamed from Budget Provider to Performance Budget
IConcurrentBudgetProvider -> IReleasablePerformanceBudget renamed as well