Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jobify scenes sorting #239

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Jobify scenes sorting #239

merged 2 commits into from
Jan 2, 2024

Conversation

mikhail-dcl
Copy link
Collaborator

The problem with sorting performance starts to appear when MaxLoadingDistanceInParcels is big, for example 50

Before:

Screenshot 2023-12-29 151501

After:

Screenshot 2023-12-29 172632

Job impact is hardly noticeable (the screenshot is taken in Deep Profiling) but throttling in frames can be quite high depending on the current load: 5-10 frames.

Screenshot 2023-12-29 170159

@mikhail-dcl mikhail-dcl added the no QA needed Used to tag pull requests that does not require QA validation label Dec 29, 2023
@mikhail-dcl mikhail-dcl removed the request for review from anicalbano December 29, 2023 14:40
Copy link
Contributor

github-actions bot commented Dec 29, 2023

badge

Windows build successfull! You can find a link to the downloadable artifact below.

Name Link
Commit b2875d0
Logs https://github.com/decentraland/unity-explorer/actions/runs/7385049321
Download https://github.com/decentraland/unity-explorer/suites/19444788776/artifacts/1142904093

@m3taphysics m3taphysics enabled auto-merge (squash) January 2, 2024 11:04
@m3taphysics m3taphysics merged commit 0668b4a into main Jan 2, 2024
3 checks passed
@m3taphysics m3taphysics deleted the fix/scene-sorting-performance branch January 2, 2024 11:37
Kinerius pushed a commit that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no QA needed Used to tag pull requests that does not require QA validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants