Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade Arch to 1.2.7 #234

Merged
merged 4 commits into from
Jan 5, 2024
Merged

chore: Upgrade Arch to 1.2.7 #234

merged 4 commits into from
Jan 5, 2024

Conversation

mikhail-dcl
Copy link
Collaborator

@mikhail-dcl mikhail-dcl commented Dec 26, 2023

Summary

Despite the declared performance improvements the difference is rather negligible.
There are noticeable differences for Component Removal, however, they show up only at 5000 entities changes at a time which is unachievable in the Decentraland environment

Before:
Screenshot 2023-12-26 170602

After:
Screenshot 2023-12-26 171237

How to test it:

  • Perform quick regression to ensure the framework itself has not introduced any issues

# Conflicts:
#	Explorer/Assets/DCL/Tests/Editor/DCL.EditMode.Tests.asmdef
Copy link
Contributor

github-actions bot commented Jan 4, 2024

badge

Windows build successfull! You can find a link to the downloadable artifact below.

Name Link
Commit fc6a2b3
Logs https://github.com/decentraland/unity-explorer/actions/runs/7422592481
Download https://github.com/decentraland/unity-explorer/suites/19539474710/artifacts/1150161640

@m3taphysics m3taphysics enabled auto-merge (squash) January 5, 2024 13:46
@m3taphysics m3taphysics merged commit d590f48 into main Jan 5, 2024
3 checks passed
@m3taphysics m3taphysics deleted the chore/arch-1.2.7 branch January 5, 2024 14:59
Kinerius pushed a commit that referenced this pull request Feb 20, 2024
* Upgrade Arch to 1.2.7

* Fix builder error

---------

Signed-off-by: Ashley Canning <[email protected]>
Co-authored-by: Ashley Canning <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants