-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: backpack controller bus #219
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: davidejensen <[email protected]>
…entraland/unity-explorer into feat/backpack-controller-bus
Windows build successfull! You can find a link to the downloadable artifact below.
|
mikhail-dcl
requested changes
Jan 8, 2024
Explorer/Assets/DCL/AvatarRendering/Wearables/Systems/ResolveWearableThumbnailSystem.cs
Outdated
Show resolved
Hide resolved
Explorer/Assets/DCL/AvatarRendering/Wearables/Components/IWearable.cs
Outdated
Show resolved
Hide resolved
Explorer/Assets/DCL/AvatarRendering/Wearables/Components/Wearable.cs
Outdated
Show resolved
Hide resolved
Explorer/Assets/DCL/AvatarRendering/Wearables/Components/WearableThumbnailComponent.cs
Outdated
Show resolved
Hide resolved
Explorer/Assets/DCL/AvatarRendering/Wearables/Systems/LoadWearablesByParamSystem.cs
Outdated
Show resolved
Hide resolved
Explorer/Assets/DCL/AvatarRendering/Wearables/Systems/LoadWearablesByParamSystem.cs
Outdated
Show resolved
Hide resolved
Explorer/Assets/DCL/AvatarRendering/Wearables/Systems/ResolveWearableByPointerSystem.cs
Outdated
Show resolved
Hide resolved
Signed-off-by: davidejensen <[email protected]>
mikhail-dcl
requested changes
Jan 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great 💚 But cancellation in two places is missing
mikhail-dcl
approved these changes
Jan 9, 2024
Kinerius
pushed a commit
that referenced
this pull request
Feb 20, 2024
* Feat: add backpack bus logic * Added structure for commands and events * Additions to backpack bus * Minor changes * Minor changes * Additional structural changes * Minor changes * Minor changes * Delete duplicated common textures * Organise and move textures to their proper folder * Add and update backpack textures * Update AvatarSlot.prefab * Changed bus messages and added equippables definition * Update BackpackItem.prefab * Update ItemInfoPanel.prefab * Update assets * Polish UI from backpack and slot * Minor changes * Load default wearable * code cleaning * Added sample retrieval of equipped wearables * Added wearable thumbnail resolver and initial equipped wearables logic * Structural changes to equipped wearables loading * Minor fixes * Minor cleanup * Minor test fix * Minor changes to wearables and wearables grid * Wired info panel behaviour in backpack * Minor changes * Applied code suggestions * Removed unneded plugin for backpack bus controller * Improvement for hash locating in wearables * Improved request params handling * Improved thumbnail resolve type * minor improvements to info panel * Minor UI improvements * Minor UI changes * Additional code suggestions applied * Removed hardcoded wallet id --------- Signed-off-by: davidejensen <[email protected]> Co-authored-by: Romina Marchetti <[email protected]> Co-authored-by: Juan Molteni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.