Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: backpack controller bus #219

Merged
merged 56 commits into from
Jan 9, 2024
Merged

Conversation

davidejensen
Copy link
Member

No description provided.

@davidejensen davidejensen self-assigned this Dec 20, 2023
Copy link
Contributor

github-actions bot commented Jan 4, 2024

badge

Windows build successfull! You can find a link to the downloadable artifact below.

Name Link
Commit 1dd7f8d
Logs https://github.com/decentraland/unity-explorer/actions/runs/7463121417
Download https://github.com/decentraland/unity-explorer/suites/19635939126/artifacts/1157107378

@davidejensen davidejensen enabled auto-merge (squash) January 9, 2024 10:41
Copy link
Collaborator

@mikhail-dcl mikhail-dcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great 💚 But cancellation in two places is missing

Explorer/Assets/DCL/Backpack/BackpackSlotsController.cs Outdated Show resolved Hide resolved
@davidejensen davidejensen merged commit 8a5ff30 into main Jan 9, 2024
3 checks passed
@davidejensen davidejensen deleted the feat/backpack-controller-bus branch January 9, 2024 15:43
Kinerius pushed a commit that referenced this pull request Feb 20, 2024
* Feat: add backpack bus logic

* Added structure for commands and events

* Additions to backpack bus

* Minor changes

* Minor changes

* Additional structural changes

* Minor changes

* Minor changes

* Delete duplicated common textures

* Organise and move textures to their proper folder

* Add and update backpack textures

* Update AvatarSlot.prefab

* Changed bus messages and added equippables definition

* Update BackpackItem.prefab

* Update ItemInfoPanel.prefab

* Update assets

* Polish UI from backpack and slot

* Minor changes

* Load default wearable

* code cleaning

* Added sample retrieval of equipped wearables

* Added wearable thumbnail resolver and initial equipped wearables logic

* Structural changes to equipped wearables loading

* Minor fixes

* Minor cleanup

* Minor test fix

* Minor changes to wearables and wearables grid

* Wired info panel behaviour in backpack

* Minor changes

* Applied code suggestions

* Removed unneded plugin for backpack bus controller

* Improvement for hash locating in wearables

* Improved request params handling

* Improved thumbnail resolve type

* minor improvements to info panel

* Minor UI improvements

* Minor UI changes

* Additional code suggestions applied

* Removed hardcoded wallet id

---------

Signed-off-by: davidejensen <[email protected]>
Co-authored-by: Romina Marchetti <[email protected]>
Co-authored-by: Juan Molteni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no QA needed Used to tag pull requests that does not require QA validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants