Fix: multiplayer movement uncompressed with rotation #2112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below.
|
github-actions
bot
requested review from
lorux0,
Ludmilafantaniella and
mikhail-dcl
popuz
requested review from
pravusjif and
NickKhalow
and removed request for
lorux0
sandrade-dcl
approved these changes
Sep 20, 2024
fcolarich
approved these changes
Sep 20, 2024
pravusjif
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
The SDK Camera Controls probably won't work 100% as expected due to the protocol update in this PR.
But that has already been tackled in this other PR.
To merge that other PR We're waiting for a test coverage PR that will be merged soon.
Conclusion: We can merge this PR and even though some SDK camera control stuff will probably break, we'll be merging today the other PR that fixes that.
…ssed-with-rotation
…ssed-with-rotation # Conflicts: # scripts/package-lock.json # scripts/package.json
Ludmilafantaniella
approved these changes
Sep 20, 2024
m3taphysics
deleted the
fix/multiplayer/movement-uncompressed-with-rotation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
How to test the changes?
It is a multiplayer feature, so playtest with 2 players - one on Win, another on Mac
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md