Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: teleport not properly working #210

Merged
merged 2 commits into from
Dec 18, 2023
Merged

fix: teleport not properly working #210

merged 2 commits into from
Dec 18, 2023

Conversation

Kinerius
Copy link
Contributor

Changes

  • Since the world floor is considered a platform, we were not updating the new local position of the platform so we were bouncing back on the next update cycle
  • The teleport is now just a reposition and not a CharacterController.Move since it will collide with stuff
  • Refactored multiple calls to CharacterController.Move into one, this might cause some issues with wall sliding but its also recommended by Unity.

How to test

  • Load any realm
  • Teleport

@Kinerius Kinerius self-assigned this Dec 14, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 14, 2023 •
edited
Loading

badge

Windows build successfull! You can find a link to the downloadable artifact below.

Name Link
Commit 3f6d714
Logs https://github.com/decentraland/unity-explorer/actions/runs/7249035658
Download https://github.com/decentraland/unity-explorer/suites/19139916707/artifacts/1121541050

@popuz popuz requested a review from anicalbano December 15, 2023 10:47
anicalbano
anicalbano approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@anicalbano anicalbano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Reviewed by QA

15.12.2023_08.29.31_REC.mp4

@Kinerius Kinerius enabled auto-merge (squash) December 15, 2023 14:33
@Kinerius Kinerius merged commit d50c990 into main Dec 18, 2023
3 checks passed
@Kinerius Kinerius deleted the fix/teleport branch December 18, 2023 14:16
Kinerius added a commit that referenced this pull request Feb 20, 2024
@Kinerius
fix: teleport not properly working (#210)
f0378f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anicalbano anicalbano anicalbano approved these changes

@popuz popuz popuz approved these changes

@mikhail-dcl mikhail-dcl Awaiting requested review from mikhail-dcl

Assignees

@Kinerius Kinerius

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kinerius @popuz @anicalbano @m3taphysics