fix: sdk hot reload models caching #2095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pravusjif
added
no QA needed
|
Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below.
|
dalkia
approved these changes
Sep 18, 2024
davidejensen
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
During local scene development, when using the hot reload (scene reloads when any change in the sdk-side of the locally running scene is made) the 3D models are not updated whtn the scene is reloaded. So if the creator had changed the model, after the hot reload they still see the old verion.
Issue: #2082
WHAT
Added local scene development check when using cache at gltfAsset preparation.
DEMO VIDEO WITH FIX
Screen.Recording.2024-09-18.at.6.02.00.PM.mp4