Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed color picker slider faded color #2092

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

davidejensen
Copy link
Member

What does this PR change?

Fix #2045
Resets the colors of the slider to the original bright value

...

How to test the changes?

  1. Launch the explorer
  2. Open the backpack
  3. Open the color picker
  4. Verify that the slider colors appear correctly and not faded out

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

Copy link
Contributor

github-actions bot commented Sep 18, 2024

badge

Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below.

Name Link
Commit 3100b34
Logs https://github.com/decentraland/unity-explorer/actions/runs/10923322118
Download Windows https://github.com/decentraland/unity-explorer/suites/28543183695/artifacts/1948363209
Download Mac https://github.com/decentraland/unity-explorer/suites/28543183695/artifacts/1948636573
Built on 2024-09-18T15:33:56Z

@pravusjif pravusjif removed the request for review from dalkia September 18, 2024 14:24
@DafGreco DafGreco self-requested a review September 18, 2024 15:35
Copy link

@DafGreco DafGreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Windows
✔️ Macos

Fix verified on both platforms

Copy link

@Ludmilafantaniella Ludmilafantaniella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Fix verifiedd on Mac and Windows. Approved by QA.

Screenshot 2024-09-18 at 12 46 29 PM

@davidejensen davidejensen merged commit a9533dd into main Sep 19, 2024
6 checks passed
@davidejensen davidejensen deleted the fix/color-picker-faded-colors branch September 19, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QA] Backpack Color Picker Visual Issue - Colors Appear Washed Out
5 participants