-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Rendering/sky box v2 sun moon and stars #207
Conversation
* Move to the separate plugin * Move logic to the system * Jobify math ops
…nMoonAndStars # Conflicts: # Explorer/Assets/DCL/AvatarRendering/AvatarShape/AvatarShape.asmdef # Explorer/Assets/DCL/InfiniteFloor/Floor.mat # Explorer/Assets/DCL/PerformanceAndDiagnostics/DebugUtilities/DebugUtilitiesContainer.cs # Explorer/Assets/DCL/PerformanceAndDiagnostics/DebugUtilities/Declarations/DebugIntSliderDef.cs # Explorer/Assets/DCL/PerformanceAndDiagnostics/DebugUtilities/Declarations/DebugIntSliderDef.cs.meta # Explorer/Assets/DCL/PerformanceAndDiagnostics/DebugUtilities/Views/Assets/DebugIntSlider.uxml # Explorer/Assets/DCL/PerformanceAndDiagnostics/DebugUtilities/Views/Assets/DebugIntSlider.uxml.meta # Explorer/Assets/DCL/PerformanceAndDiagnostics/DebugUtilities/Views/DebugIntSliderElement.cs # Explorer/Assets/DCL/PerformanceAndDiagnostics/DebugUtilities/Views/DebugIntSliderElement.cs.meta # Explorer/Assets/DCL/PluginSystem/DCL.Plugins.asmdef # Explorer/Assets/DCL/PluginSystem/Global/Global Plugins Settings.asset # Explorer/Assets/DCL/Rendering/SkyBox/DCL_RenderFeature_ProceduralSkyBox.cs # Explorer/Assets/DCL/Rendering/SkyBox/DCL_RenderPass_GenerateSkyBox.cs # Explorer/Assets/DCL/SkyBox/Rendering/DCL_RenderPass_DrawSkyBox.cs # Explorer/Assets/Resources.meta # Explorer/Assets/Scenes/DynamicSceneLoading.unity # Explorer/Assets/Scripts/Global/Dynamic/DynamicSceneLoader.cs # Explorer/Assets/Scripts/Global/Dynamic/DynamicWorldContainer.cs # Explorer/DCL.Plugins.csproj.DotSettings
Windows build successfull! You can find a link to the downloadable artifact below.
|
…nMoonAndStars # Conflicts: # Explorer/Assets/DCL/PluginSystem/DCL.Plugins.asmdef # Explorer/Assets/DCL/PluginSystem/Global/Global Plugins Settings.asset # Explorer/Assets/Scenes/DynamicSceneLoading.unity # Explorer/Assets/Scripts/Global/Dynamic/DynamicSceneLoader.cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on Mac as well. I was able to reproduce Ani's issue with the night sky on the horizon when it's still day.
The directional light matches the position and rotation of illuminating elements (sun or moon) with corresponding color and intensity variations based on time marks.
# Conflicts: # Explorer/Assets/DCL/PluginSystem/DCL.Plugins.asmdef # Explorer/Assets/DCL/PluginSystem/Global/Global Plugins Settings.asset # Explorer/Assets/Scenes/DynamicSceneLoading.unity # Explorer/Assets/Scripts/Global/Dynamic/DynamicSceneLoader.cs # Explorer/Assets/Scripts/Global/Dynamic/DynamicWorldContainer.cs
With @GBirch33 we fixed the forementioned bugs |
* Calibration of SkyBox sun coord, addition of BSC5 stars * Compute vs Pixel shader star rendering. * Create an utility to hot reload compute shaders * TimeOfDay - Skybox * Arrange SkyBox according to the architecture * Move to the separate plugin * Move logic to the system * Jobify math ops --------- Co-authored-by: Geoff Birch <[email protected]>
From the Unity side this is what should be done to target the production quality:
MissingReferenceException
on scene changeMarshal.SizeOf
How to test:
Use the debug panel to control values.
They should change the appearance of the sky box both in Editor and Build. In case of doubts @GBirch33 should be able to provide details of the time of day algorithm.
There should be no exceptions related to Sky Box at any point with any values.