feat: UITransform and UIText SDK components #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandrade-dcl
changed the title
sandrade-dcl
changed the title
sandrade-dcl
changed the title
sandrade-dcl
changed the title
mikhail-dcl
requested changes
Jan 3, 2024
Explorer/Assets/DCL/SDKComponents/SceneUI/Systems/UITransformHandlerSystem.cs
Outdated
Show resolved
Hide resolved
Explorer/Assets/DCL/SDKComponents/SceneUI/Systems/UITextHandlerSystem.cs
Outdated
Show resolved
Hide resolved
github-actions
bot
requested review from
anicalbano,
mikhail-dcl and
pravusjif
sandrade-dcl
changed the title
sandrade-dcl
changed the title
mikhail-dcl
requested changes
Jan 11, 2024
Explorer/Assets/DCL/SDKComponents/SceneUI/Components/UITransformComponent.cs
Outdated
Show resolved
Hide resolved
Explorer/Assets/DCL/SDKComponents/SceneUI/ScenesUIStyleSheet.uss
Outdated
Show resolved
Hide resolved
Explorer/Assets/DCL/SDKComponents/SceneUI/Systems/UIText/UITextReleaseSystem.cs
Outdated
Show resolved
Hide resolved
Explorer/Assets/DCL/SDKComponents/SceneUI/Systems/UITransform/UITransformParentingSystem.cs
Show resolved
Hide resolved
Explorer/Assets/DCL/SDKComponents/SceneUI/Systems/UITransform/UITransformReleaseSystem.cs
Outdated
Show resolved
Hide resolved
Explorer/Assets/DCL/SDKComponents/SceneUI/Systems/UITransform/UITransformSortingSystem.cs
Outdated
Show resolved
Hide resolved
Explorer/Assets/DCL/SDKComponents/SceneUI/Systems/UITransform/UITransformUpdateSystem.cs
Show resolved
Hide resolved
Explorer/Assets/DCL/SDKComponents/SceneUI/Systems/UITransform/UITransformUpdateSystem.cs
Outdated
Show resolved
Hide resolved
Explorer/Assets/DCL/SDKComponents/SceneUI/Tests/UITransformInstantiationSystemShould.cs
Outdated
Show resolved
Hide resolved
… old UITransform parent
* Upgrade TestFramework to 1.4.2 * Async Setup/Teardown issue fixed * More stable
… into feat/sdk7-compatibility-ui-text # Conflicts: # Explorer/Assets/Scripts/Global/Dynamic/DynamicSceneLoader.cs
mikhail-dcl
approved these changes
Jan 12, 2024
* No need to pass it * Remove direct usage of Addressable API
… into feat/sdk7-compatibility-ui-text
Kinerius
pushed a commit
that referenced
this pull request
Feb 20, 2024
* Create global UIDocument for scenes UI + start implementing UIText systems * Fix IntegrationTestsSuite * Move SceneUI folder to DCL/SDKComponents * Handle UIText removal * Update SceneUIPlugin.cs * Update UITextHandlerSystem.cs * Setup canvas with the default configuration * Move ProtoConvertUtils and UiElementUtils under SceneUI folder * Implement UITransform * Create a style sheet for the main canvas * Update UITransformHandlerSystem.cs * Fix tests * Move the release logic to separated systems * Make UITransformInstantiationSystem executes first of all the rest of systems * Apply parenting to UIText * Set a name for each component * UITransform: parenting and sorting * Add an option to clear PB components on Get * Set default values in UiElementUtils.SetupVisualElement function * Implement detection of the current scene * Hide scene UI when we're out of the scene * UIText test coverage * Reset processed parcel on realm invalidation * UITransformInstantiation test coverage * UITransformUpdate test coverage * Apply feedback: Add maxSize to AddComponentPool method * Fix code conventions tests * Fix async tests * Upgrade TestFramework to 1.4.2 * Async Setup/Teardown issue fixed * More stable --------- Co-authored-by: Mikhail Agapov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR includes?
Implemented systems
UITransform
UITransformInstantiationSystemUITransformParentingSystemUITransformSortingSystemUITransformUpdateSystemUITransformReleaseSystemUIText
UITextInstantiationSystemUITextReleaseSystem