Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: 1742 map centering #1864

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Fix: 1742 map centering #1864

merged 2 commits into from
Aug 26, 2024

Conversation

NickKhalow
Copy link
Contributor

What does this PR change?

PR centers map on its activation

How to test the changes?

Follow the ticket: #1742

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

@NickKhalow NickKhalow self-assigned this Aug 23, 2024
@NickKhalow NickKhalow linked an issue Aug 23, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Aug 23, 2024

badge

Build failed! Check the logs to see what went wrong

Copy link

@Ludmilafantaniella Ludmilafantaniella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Fix verified and approved by QA. Map is always centered on player's position.

Explorer.2024-08-23.15-06-24.mp4

@NickKhalow NickKhalow merged commit cc9aa48 into main Aug 26, 2024
5 of 6 checks passed
@NickKhalow NickKhalow deleted the fix/1742-map-centering branch August 26, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QA] Map doesn't center on player's position
3 participants