Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lods removing from scene cache #1857

Merged
merged 13 commits into from
Aug 26, 2024
Merged

fix: lods removing from scene cache #1857

merged 13 commits into from
Aug 26, 2024

Conversation

dalkia
Copy link
Collaborator

@dalkia dalkia commented Aug 22, 2024

What does this PR change?

  • LODs are added to the scene cache on instantiation. When disposed, they are removed.
    When required again, they were retrieved from the LOD cache, but not added to the scene cache. Generating timeout on the loading screen, since this one never knew that the LODs were ready. This PR adds back to the scene cache when gotten from the LOD cache

  • Also, adds an unload immediate on dispose, since profiler is not available at this time and we dont care about hiccups while closing the application.

How to test the changes?

  • Test 1
  1. Launch the explorer. Starting in GP
  2. Go to 100,100
  3. Go to Airdrop Castle (-7,-18)
  4. Go to 100,100
  5. Go to Airdrop Castle (-7,-718)
  6. The second teleports should be almost instantaneous
  • Test 2
  1. Launch the explorer. Starting in GP
  2. Go to ALTIX (113,18)
  3. Go back to GP
  4. Go to ALTIX (113,18)
  5. The second teleports should be almost instantenous

Repeat with any scene you know its a LOD. Do the same process with roads and empty parcels

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

Copy link
Contributor

github-actions bot commented Aug 22, 2024

badge

Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below.

Name Link
Commit 1dbe94b
Logs https://github.com/decentraland/unity-explorer/actions/runs/10566063712
Download Windows https://github.com/decentraland/unity-explorer/suites/27619506880/artifacts/1856355944
Download Mac https://github.com/decentraland/unity-explorer/suites/27619506880/artifacts/1856340062
Built on 2024-08-26T20:09:22Z

@dalkia dalkia changed the title test: lod cache fix: lods removing from scene cache Aug 23, 2024
Explorer/Assets/DCL/LOD/Systems/LODUtils.cs Outdated Show resolved Hide resolved
Explorer/Assets/DCL/LOD/Systems/LODUtils.cs Outdated Show resolved Hide resolved
Copy link

@Ludmilafantaniella Ludmilafantaniella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Fix verified on Mac and windows. Approved by QA.

@dalkia dalkia enabled auto-merge (squash) August 26, 2024 19:33
@dalkia dalkia merged commit 11ffe9f into main Aug 26, 2024
5 checks passed
@dalkia dalkia deleted the fix/lod-cache branch August 26, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants