Fix: nethereum signing memory #1830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Explorer/Assets/DCL/AvatarRendering/Wearables/Wearables.asmdef
|
New build in progress, come back later! |
lorux0
requested changes
Aug 20, 2024
Ludmilafantaniella
approved these changes
Aug 21, 2024
mikhail-dcl
approved these changes
Aug 26, 2024
# Conflicts: # Explorer/Assets/DCL/FeatureFlags/DCL.FeatureFlags.asmdef # Explorer/Assets/DCL/PluginSystem/DCL.Plugins.asmdef # Explorer/Assets/DCL/Tests/PlayMode/DCL.PlayMode.Tests.asmdef # Explorer/Assets/DCL/UserInAppInitializationFlow/DCL.UserInAppInitializationFlow.asmdef # Explorer/Assets/Scripts/Global/Dynamic/BootstrapContainer.cs # Explorer/Assets/Scripts/Global/Static/StaticSceneLauncher.cs # Explorer/Assets/Scripts/SceneRuntime/SceneRuntime.asmdef
lorux0
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
fix #1798
Integrated Alloy rust library for the performance bottle with nethereum.
It gave a crazy performance boost per 120 times 31.4 ms -> 0.26 ms, and reduced memory allocation per 1500 times 3.83 Mb -> 2.63 Kb
RustEthereum.mov
How to test the changes?
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md