Fixed UI not updating correctly using PBUiCanvasInformation

decentraland · Dec 20, 2024 · 02d496d · 02d496d
1 parent fa63ac6
commit 02d496d
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/...Assets/DCL/SDKComponents/SceneUI/Systems/UICanvasInformation/UICanvasInformationSystem.cs b/...Assets/DCL/SDKComponents/SceneUI/Systems/UICanvasInformation/UICanvasInformationSystem.cs
@@ -23,6 +23,8 @@ public partial class UICanvasInformationSystem : BaseUnityLoopSystem
         private BorderRect interactableArea;
         private int lastViewportResolutionWidth = -1;
         private int lastScreenRealResolutionWidth = -1;
+        private const int TOTAL_ATTEMPTS = 3;
+        private int currentAttempts = 0;
 
         public override void Initialize()
         {
@@ -36,6 +38,7 @@ private UICanvasInformationSystem(World world, ISceneStateProvider sceneStatePro
         {
             this.sceneStateProvider = sceneStateProvider;
             this.ecsToCRDTWriter = ecsToCRDTWriter;
+            currentAttempts = 0;
         }
 
         protected override void Update(float t)
@@ -53,12 +56,17 @@ private void PropagateToScene()
         private void UpdateUICanvasInformationComponent()
         {
             if (lastViewportResolutionWidth == Screen.width && lastScreenRealResolutionWidth == Screen.mainWindowDisplayInfo.width)
-                return;
+            {
+                //We add this logic because in the first frames the message might get lost and we wont send correctly the size of the screen
+                //to the scene, causing breaking UIs
+                if (currentAttempts > TOTAL_ATTEMPTS) { return; }
+                currentAttempts++;
+            }
 
             lastScreenRealResolutionWidth = Screen.mainWindowDisplayInfo.width;
             lastViewportResolutionWidth = Screen.width;
 
-            ecsToCRDTWriter.PutMessage<PBUiCanvasInformation, UICanvasInformationSystem>(static (component, system) =>
+            ecsToCRDTWriter.PutMessage<PBUiCanvasInformation, UICanvasInformationSystem>((component, system) =>
             {
                 component.InteractableArea = system.interactableArea;
                 component.Width = Screen.width;