Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: RPC services to different files + tests #31

Merged
merged 15 commits into from
Jan 15, 2025
Merged

refactor: RPC services to different files + tests #31

merged 15 commits into from
Jan 15, 2025

Conversation

kevinszuchet
Copy link
Contributor

No description provided.

@kevinszuchet kevinszuchet marked this pull request as draft January 13, 2025 20:52
@coveralls
Copy link

coveralls commented Jan 13, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12777587749

Details

  • 139 of 160 (86.88%) changed or added relevant lines in 13 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+41.7%) to 57.604%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/adapters/rpc-server/index.ts 0 1 0.0%
src/adapters/rpc-server/services/get-friends.ts 20 21 95.24%
src/components.ts 0 1 0.0%
src/controllers/handlers/ws-handler.ts 0 3 0.0%
src/adapters/rpc-server/services/subscribe-to-friendship-updates.ts 11 16 68.75%
src/adapters/rpc-server/rpc-server.ts 26 36 72.22%
Files with Coverage Reduction New Missed Lines %
src/adapters/ws.ts 1 0.0%
Totals Coverage Status
Change from base Build 12749288128: 41.7%
Covered Lines: 282
Relevant Lines: 495
💛 - Coveralls

aleortega
aleortega approved these changes Jan 13, 2025
View reviewed changes
Copy link

@aleortega aleortega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/adapters/rpc-server/services/get-mutual-friends.ts Show resolved Hide resolved
@kevinszuchet kevinszuchet marked this pull request as ready for review January 14, 2025 14:39
@kevinszuchet kevinszuchet merged commit a66b796 into main Jan 15, 2025
4 checks passed
@kevinszuchet kevinszuchet deleted the refactor/rpc-services-to-different-files branch January 15, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleortega aleortega aleortega approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevinszuchet @coveralls @aleortega