-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add lists page #1747
feat: Add lists page #1747
Conversation
…and/marketplace into feat/lists-page
webapp/src/components/ProtectedRoute/ProtectedRoute.container.ts
Outdated
Show resolved
Hide resolved
import { Props } from './ProtectedRoute.types' | ||
|
||
const ProtectedRoute = (props: Props) => { | ||
const { isConnecting, wallet, ...rest } = props |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYT about taking these props (isConnecting
& wallet
) from a custom container called ProtectedRoute.container.ts
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand the question because the container is above this file. Can you show me an example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I meant having a ProtectedRoute.container.ts
like this:
const mapState = (state: RootState): MapStateProps =>
({
wallet: getWallet(state),
isConnecting: isConnecting(state),
});
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Print it 🖨️
This PR does the following:
Routes
component.Closes #1718