feat: Deploy to land #277
Merged
feat: Deploy to land #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyaiox
force-pushed
the
feat/deploy-to-land
branch
from
4bccfdd to
ca67780
Compare
cazala
reviewed
Oct 29, 2024
| dispatch(identify({ userId: wallet })); | ||
| dispatch(fetchTiles({ chainId: ChainId.ETHEREUM_SEPOLIA })); | ||
| dispatch(fetchLandList({ address: wallet, chainId: ChainId.ETHEREUM_SEPOLIA })); |
There was a problem hiding this comment.
Are these sepolia chain ids meant to be here or were there for testing?
There was a problem hiding this comment.
good catch, removed! were there for testing
cyaiox
force-pushed
the
feat/deploy-to-land
branch
from
d27ed5e to
2f33bb9
Compare
cyaiox
commented
Oct 29, 2024
| @@ -278,15 +280,14 @@ export async function updateProject(project: Project): Promise<Project> { | |||
| } | |||
| } | |||
|
|
|||
| if (updatedProject.updatedAt > project.updatedAt) { | |||
There was a problem hiding this comment.
validation was added to detect whether the method updateProject was called by the sceneUpdate RPC or manually.
Test this pull request on windows-latestDownload the correct version for your architecture: |
cazala
approved these changes
Oct 29, 2024
|
LGTM ✅ ! |
Test this pull request on macos-latestDownload the correct version for your architecture:Click here if you don't know which version to downloadFor running this unsigned version of the app, you will need to run the xattr command on it:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Adds the publish to land logic
Depends on: decentraland/ui2#200