feat: Add campaign module and banners #3240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pull Request Test Coverage Report for Build 12886743242Details
💛 - Coveralls |
…e memory footprint
LautaroPetaccio
commented
Jan 21, 2025
| @@ -62,7 +62,7 @@ export default defineConfig(({ mode }) => { | |||
| commonjsOptions: { | |||
| transformMixedEsModules: true | |||
| }, | |||
| sourcemap: true | |||
| sourcemap: false | |||
There was a problem hiding this comment.
Removing the sourcemaps is a tradeoff that we need to take at this moment, as building the distributable in vercel is quite impossible.
cyaiox
reviewed
Jan 21, 2025
| @@ -38,6 +38,7 @@ import CollectionRow from './CollectionRow' | |||
| import { Props, TABS } from './CollectionsPage.types' | |||
| import './CollectionsPage.css' | |||
|
|
|||
| const BUILDER_BANNER_ID = 'builderCampaignBanner' | |||
There was a problem hiding this comment.
should we move this const to modules/common/types?
cyaiox
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new campaign module and the code to display the banners and use the campaign data from the module.
It also removes all of the old code that was used to display the banners.
The configurations are only set on dev, as the final entities and keys are to be set before the release.