Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ethereum address mapping #3015

Merged
merged 6 commits into from
Jan 16, 2024
Merged

feat: add ethereum address mapping #3015

merged 6 commits into from
Jan 16, 2024

Conversation

meelrossi
Copy link

Add ethereum address mapping for decentraland names

image image

@vercel Vercel
Copy link

vercel bot commented Jan 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 9:41pm

@coveralls
Copy link

coveralls commented Jan 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7547819654

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on feat/add-ens-address at 18.03%
Totals Coverage Status
Change from base Build 7504546721: 18.0%
Covered Lines: 3714
Relevant Lines: 16595
💛 - Coveralls

LautaroPetaccio
LautaroPetaccio reviewed Jan 15, 2024
View reviewed changes
Copy link
Contributor

@LautaroPetaccio LautaroPetaccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🥇
I've left some comments to review

src/modules/translation/languages/en.json Show resolved Hide resolved
src/modules/ens/selectors.ts Show resolved Hide resolved
src/components/ENSListPage/utils.ts Outdated Show resolved Hide resolved
src/modules/ens/sagas.ts Outdated Show resolved Hide resolved
src/modules/ens/sagas.ts Show resolved Hide resolved
src/components/Modals/ENSMapAddressModal/ENSMapAddressModal.tsx Show resolved Hide resolved
src/components/Modals/ENSMapAddressModal/ENSMapAddressModal.tsx Show resolved Hide resolved
src/components/ENSListPage/ENSListPage.tsx Show resolved Hide resolved
src/modules/translation/languages/en.json Outdated Show resolved Hide resolved
src/components/Modals/ENSMapAddressModal/ENSMapAddressModal.tsx Outdated Show resolved Hide resolved
@meelrossi meelrossi force-pushed the feat/add-ens-address branch from 0f41873 to 55efe05 Compare January 16, 2024 17:37
@meelrossi meelrossi force-pushed the feat/add-ens-address branch from 55efe05 to 06fa5c7 Compare January 16, 2024 20:24
@meelrossi meelrossi force-pushed the feat/add-ens-address branch from 06fa5c7 to 8ce3f3d Compare January 16, 2024 21:07
LautaroPetaccio
LautaroPetaccio approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@LautaroPetaccio LautaroPetaccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Melisa Anabella Rossi added 2 commits January 16, 2024 18:32
@meelrossi meelrossi merged commit 0002080 into master Jan 16, 2024
7 checks passed
@meelrossi meelrossi deleted the feat/add-ens-address branch January 16, 2024 21:56
meelrossi pushed a commit that referenced this pull request Jan 19, 2024
feat: add ethereum address mapping (#3015)
e818c80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LautaroPetaccio LautaroPetaccio LautaroPetaccio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meelrossi @coveralls @LautaroPetaccio