fix: wrong feature flag #3004
Merged
fix: wrong feature flag #3004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pull Request Test Coverage Report for Build 7339284056
💛 - Coveralls |
meelrossi
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with feature flags.
When both feature flags
builder-create-scene-only-sdk7andbuilder-sdk7-templatesare OFF (as it is the case in PRD) everything is fine. When both flags are ON as they were in DEV and STG then everything is fine too.The problem is when
builder-sdk7-templatesis ON andbuilder-create-scene-only-sdk7is OFF, then the scene creation flow allows you to choose which SDK version to use, but it will always create the scene using SDK7... this was because theisSDK7TemplatesEnabledproperty was wrongly used in the submit handler of the scene creation flow..This PR fixes that issue so the two feature flags can be used separately, which is necessary to release the SDK7 templates without disabling the creation of SDK6 scenes.