Skip to content

Commit

Permalink
fix: Unify the banner id variable
Browse files Browse the repository at this point in the history
  • Loading branch information
LautaroPetaccio committed Jan 21, 2025
1 parent 21ade5b commit f91ceb9
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/components/CollectionsPage/CollectionsPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import { CollectionPageView } from 'modules/ui/collection/types'
import { CurationSortOptions } from 'modules/curations/types'
import { usePagination } from 'lib/pagination'
import { CollectionType } from 'modules/collection/types'
import { BUILDER_BANNER_ID } from 'modules/common/banners'
import collectionsIcon from 'icons/collections.svg'
import ItemCard from './ItemCard'
import ItemRow from './ItemRow'
Expand All @@ -38,7 +39,6 @@ import CollectionRow from './CollectionRow'
import { Props, TABS } from './CollectionsPage.types'
import './CollectionsPage.css'

const BUILDER_BANNER_ID = 'builderCampaignBanner'
const PAGE_SIZE = 20
export const LOCALSTORAGE_EMOTES_V2_ANNOUCEMENT = 'builder-emotes-2.0-announcement'

Expand Down
2 changes: 1 addition & 1 deletion src/components/HomePage/HomePage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ import LoadingPage from 'components/LoadingPage'
import SyncToast from 'components/SyncToast'
import Navigation from 'components/Navigation'
import { NavigationTab } from 'components/Navigation/Navigation.types'
import { BUILDER_BANNER_ID } from 'modules/common/banners'
import { locations } from 'routing/locations'
import { Props } from './HomePage.types'
import './HomePage.css'

export const LOCALSTORAGE_LAST_VISITED_SECTION_KEY = 'builder-last-visited-section'
const BUILDER_BANNER_ID = 'builderCampaignBanner'
const localStorage = getLocalStorage()
const cards = [NavigationTab.COLLECTIONS, NavigationTab.SCENES, NavigationTab.LAND, NavigationTab.NAMES]

Expand Down
3 changes: 3 additions & 0 deletions src/modules/common/banners.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
const BUILDER_BANNER_ID = 'builderCampaignBanner'

export { BUILDER_BANNER_ID }
2 changes: 1 addition & 1 deletion tsconfig.node.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@
"moduleResolution": "bundler",
"allowSyntheticDefaultImports": true
},
"include": ["vite.config.ts"]
"include": ["vite.config.ts", "src"]
}

0 comments on commit f91ceb9

Please sign in to comment.