Skip to content

Commit

Permalink
fix: Multiple items creation with mappings only on LW v2 (#3176)
Browse files Browse the repository at this point in the history
  • Loading branch information
LautaroPetaccio authored Sep 4, 2024
1 parent c5bbedb commit 5dae44c
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import {
import { getError } from 'modules/item/selectors'
import { Collection } from 'modules/collection/types'
import { getCollection } from 'modules/collection/selectors'
import { getIsLinkedWearablesV2Enabled } from 'modules/features/selectors'
import { MapStateProps, MapDispatchProps, MapDispatch, OwnProps } from './CreateAndEditMultipleItemsModal.types'
import CreateAndEditMultipleItemsModal from './CreateAndEditMultipleItemsModal'

Expand All @@ -24,6 +25,7 @@ const mapState = (state: RootState, ownProps: OwnProps): MapStateProps => {
notSavedItemsFiles: getNotSavedItemsFiles(state),
cancelledItemsFiles: getCanceledItemsFiles(state),
saveMultipleItemsState: getMultipleItemsSaveState(state),
isLinkedWearablesV2Enabled: getIsLinkedWearablesV2Enabled(state),
saveItemsProgress: getProgress(state)
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ export default class CreateAndEditMultipleItemsModal extends React.PureComponent
}

processAcceptedFile = async (file: File) => {
const { collection, metadata } = this.props
const { collection, metadata, isLinkedWearablesV2Enabled } = this.props
try {
const fileArrayBuffer = await file.arrayBuffer()
const loadedFile = await loadFile(file.name, new Blob([new Uint8Array(fileArrayBuffer)]))
Expand Down Expand Up @@ -186,7 +186,7 @@ export default class CreateAndEditMultipleItemsModal extends React.PureComponent
}

// In case the collection is linked to a smart contract, the mappings must be present
if (collection?.linkedContractAddress && collection.linkedContractNetwork) {
if (isLinkedWearablesV2Enabled && collection?.linkedContractAddress && collection.linkedContractNetwork) {
if (!loadedFile.wearable.mapping) {
throw new Error(t('create_and_edit_multiple_items_modal.missing_mapping'))
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,14 +62,22 @@ export type Props = Omit<ModalProps, 'metadata'> & {
notSavedItemsFiles: ReturnType<typeof getNotSavedItemsFiles>
cancelledItemsFiles: ReturnType<typeof getCanceledItemsFiles>
saveMultipleItemsState: ReturnType<typeof getMultipleItemsSaveState>
isLinkedWearablesV2Enabled: boolean
saveItemsProgress: number
metadata: CreateAndEditMultipleItemsModalMetadata
}

export type OwnProps = Pick<Props, 'name' | 'metadata' | 'onClose'>
export type MapStateProps = Pick<
Props,
'savedItemsFiles' | 'notSavedItemsFiles' | 'cancelledItemsFiles' | 'error' | 'saveMultipleItemsState' | 'saveItemsProgress' | 'collection'
| 'savedItemsFiles'
| 'notSavedItemsFiles'
| 'cancelledItemsFiles'
| 'error'
| 'saveMultipleItemsState'
| 'saveItemsProgress'
| 'collection'
| 'isLinkedWearablesV2Enabled'
>
export type MapDispatchProps = Pick<Props, 'onSaveMultipleItems' | 'onCancelSaveMultipleItems' | 'onModalUnmount'>
export type MapDispatch = Dispatch<SaveMultipleItemsRequestAction | CancelSaveMultipleItemsAction | ClearStateSaveMultipleItemsAction>

0 comments on commit 5dae44c

Please sign in to comment.