Skip to content

Commit

Permalink
fix: add missing outlineCompatible prop in buildWearableEntityMetadat…
Browse files Browse the repository at this point in the history
…a fn (#3238)
  • Loading branch information
juanmahidalgo authored Jan 10, 2025
1 parent 81bd6e2 commit 33afca3
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,8 @@ export default class CreateSingleItemModal extends React.PureComponent<Props, St
tags: tags || [],
representations: [...representations],
requiredPermissions: requiredPermissions || [],
blockVrmExport: blockVrmExport ?? false
blockVrmExport: blockVrmExport ?? false,
outlineCompatible: true // it's going to be true for all the items. It can be deactivated later in the editor view
} as WearableData
} else {
data = {
Expand Down Expand Up @@ -398,7 +399,8 @@ export default class CreateSingleItemModal extends React.PureComponent<Props, St
removesDefaultHiding: removesDefaultHiding,
tags: [...editedItem.data.tags],
requiredPermissions: requiredPermissions || [],
blockVrmExport: editedItem.data.blockVrmExport
blockVrmExport: editedItem.data.blockVrmExport,
outlineCompatible: editedItem.data.outlineCompatible || true // it's going to be true for all the items. It can be deactivated later in the editor view
},
contents: {
...editedItem.contents,
Expand Down
1 change: 1 addition & 0 deletions src/modules/editor/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ export type CatalystWearable = {
}[]
}[]
blockVrmExport?: boolean
outlineCompatible?: boolean
}
i18n: { code: string; text: string }[]
createdAt: number
Expand Down
6 changes: 4 additions & 2 deletions src/modules/item/export.ts
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,8 @@ function buildTPItemEntityMetadata(item: Item, itemHash: string, tree: MerkleDis
tags: item.data.tags,
category: item.data.category as WearableCategory,
representations: item.data.representations as WearableRepresentation[],
...('blockVrmExport' in item.data ? { blockVrmExport: item.data.blockVrmExport } : {})
...('blockVrmExport' in item.data ? { blockVrmExport: item.data.blockVrmExport } : {}),
...('outlineCompatible' in item.data ? { outlineCompatible: item.data.outlineCompatible } : {})
},
image: IMAGE_PATH,
thumbnail: THUMBNAIL_PATH,
Expand Down Expand Up @@ -183,7 +184,8 @@ function buildWearableEntityMetadata(collection: Collection, item: Item): Wearab
tags: item.data.tags,
category: item.data.category!,
representations: item.data.representations,
...('blockVrmExport' in item.data ? { blockVrmExport: item.data.blockVrmExport } : {})
...('blockVrmExport' in item.data ? { blockVrmExport: item.data.blockVrmExport } : {}),
...('outlineCompatible' in item.data ? { outlineCompatible: item.data.outlineCompatible } : {})
},
image: IMAGE_PATH,
thumbnail: THUMBNAIL_PATH,
Expand Down

0 comments on commit 33afca3

Please sign in to comment.