feat: ADR 279 #283
Open
feat: ADR 279 #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying adr with
|
| Latest commit: |
29dc953
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e1d1b27d.adr-cvq.pages.dev |
| Branch Preview URL: | https://feat-adr-279.adr-cvq.pages.dev |
nachomazzara
approved these changes
Jan 16, 2025
aixaCode
requested changes
Jan 21, 2025
|
|
||
| ## Context and Problem Statement | ||
|
|
||
| The current avatar rendering system uses inverted face rendering for outlines in Medium/High quality settings. This creates conflicts with custom meshes that have manual outlines or inverted normals, resulting in incorrect rendering. Currently, there is no way to identify incompatible assets before they are rendered, leading to visual artifacts and inconsistent appearance. |
There was a problem hiding this comment.
This sentence assumes there is only one renderer in use, which is not accurate as there are alternative clients as well. I would suggest we specify that we talk about unity-explorer
juanmahidalgo
force-pushed
the
feat/adr-279
branch
from
8ad09fd to
eb3fcd8
Compare
juanmahidalgo
force-pushed
the
feat/adr-279
branch
from
eb3fcd8 to
beca5d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.