nhibernateGH-3530: Add a warning when a driver throws an exception wh…

…ile retrieving a value.
deAtog · Jun 14, 2024 · b94e807 · b94e807
1 parent f8637c7
commit b94e807
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/src/NHibernate.Test/Async/NHSpecificTest/GH3530/Fixture.cs b/src/NHibernate.Test/Async/NHSpecificTest/GH3530/Fixture.cs
@@ -12,6 +12,7 @@
 using System.Data;
 using System.Globalization;
 using System.Reflection;
+using System.Runtime.ExceptionServices;
 using System.Text;
 using NHibernate.SqlTypes;
 using NUnit.Framework;
@@ -146,12 +147,19 @@ private string GetQualifiedName(string catalog, string schema, string name)
 		using (var session = OpenSession())
 		using (var tx = session.BeginTransaction())
 		{
+			AppDomain.CurrentDomain.FirstChanceException += OnFirstChanceException;
 			var entity = await (session.GetAsync<U>(id, cancellationToken));
+			AppDomain.CurrentDomain.FirstChanceException -= OnFirstChanceException;
 
 			assert(expectedValue, entity.DataValue);
 		}
 	}
 
+	private void OnFirstChanceException(object sender, FirstChanceExceptionEventArgs e)
+	{
+		Assert.Warn($"Driver threw a {e.Exception.GetType().Name} exception while retrieving the value.");
+	}
+
 	[Test, TestCaseSource(nameof(GetTestCases))]
 	public async Task TestNHDateTimeAsync(CultureInfo from, CultureInfo to)
 	{

diff --git a/src/NHibernate.Test/NHSpecificTest/GH3530/Fixture.cs b/src/NHibernate.Test/NHSpecificTest/GH3530/Fixture.cs
@@ -2,6 +2,7 @@
 using System.Data;
 using System.Globalization;
 using System.Reflection;
+using System.Runtime.ExceptionServices;
 using System.Text;
 using NHibernate.SqlTypes;
 using NUnit.Framework;
@@ -134,12 +135,19 @@ private void PerformTest<T, U>(CultureInfo from, CultureInfo to, T expectedValue
 		using (var session = OpenSession())
 		using (var tx = session.BeginTransaction())
 		{
+			AppDomain.CurrentDomain.FirstChanceException += OnFirstChanceException;
 			var entity = session.Get<U>(id);
+			AppDomain.CurrentDomain.FirstChanceException -= OnFirstChanceException;
 
 			assert(expectedValue, entity.DataValue);
 		}
 	}
 
+	private void OnFirstChanceException(object sender, FirstChanceExceptionEventArgs e)
+	{
+		Assert.Warn($"Driver threw a {e.Exception.GetType().Name} exception while retrieving the value.");
+	}
+
 	[Test, TestCaseSource(nameof(GetTestCases))]
 	public void TestNHDateTime(CultureInfo from, CultureInfo to)
 	{