Solves (almost) all TODOs from the original author... #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
path discovering matter.
this is useful if we need test the markdown compiler job or even change the implementation form Kramdown to any other one in the future
is passed to the watcher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And simplifies the watcher statement syntax, a lot. Now when someone do a guard init markdown the thing will just works by default.
To do the changes, I refactored the original project a lot and added some specs.
Besides that, this PR adds some sugar, like changelog file, .travis.yml and such.
I don't know if the number of commits will be helpful or harmful, but I'm here to do any changes that you guys need to pull this PR if you want. Just let me know.